gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lewis John McGibbney (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GORA-474) bug in org.apache.gora.solr.store.SolrStore#getDatumWriter & #getDatumReader
Date Mon, 09 May 2016 17:03:12 GMT

    [ https://issues.apache.org/jira/browse/GORA-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276624#comment-15276624

Lewis John McGibbney commented on GORA-474:

The PR passes all tests. Thank you [~acosand] this is nice work and a nice patch and tests
for each datastore thank you. 

> bug in org.apache.gora.solr.store.SolrStore#getDatumWriter & #getDatumReader
> ----------------------------------------------------------------------------
>                 Key: GORA-474
>                 URL: https://issues.apache.org/jira/browse/GORA-474
>             Project: Apache Gora
>          Issue Type: Bug
>          Components: gora-solr
>    Affects Versions: 0.6.1
>         Environment: n/a
>            Reporter: Aaron Cosand
>            Assignee: Lewis John McGibbney
>             Fix For: 0.7
>         Attachments: SolrStore.patch, gora-test.patch, webpage.avsc
>   Original Estimate: 2h
>  Remaining Estimate: 2h
> The above referenced methods use schemaId to cache DatumReader and DatumWriter instances.
 This restricts you to using a schema type of "map" with only a single value set.  the caching
method should use a more specific identifier like what is returned from fieldSchema.toString()
instead of schemaId, so that the caching mechanism doesn't return a reader/writer that doesn't
match your data set.

This message was sent by Atlassian JIRA

View raw message