gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alfonsonishikawa <...@git.apache.org>
Subject [GitHub] gora pull request #88: GORA-495 fix
Date Wed, 21 Sep 2016 20:19:43 GMT
Github user alfonsonishikawa commented on a diff in the pull request:

    --- Diff: gora-compiler/src/main/velocity/org/apache/gora/compiler/templates/record.vm
    @@ -18,7 +18,7 @@
     #if ($schema.getNamespace())
     package $schema.getNamespace();  
    --- End diff --
    In https://issues.apache.org/jira/browse/GORA-412 where the consensus was to remove the
@SuppressWarnings("all") and let the warnings be shown in the IDE.
    I guess it will show warnings, but who cares? ;)
    I vote +1 to apply the patch :)

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message