gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lewismc <...@git.apache.org>
Subject [GitHub] gora pull request #110: Initial commit gora cassandra cql
Date Mon, 19 Jun 2017 20:19:04 GMT
Github user lewismc commented on a diff in the pull request:

    https://github.com/apache/gora/pull/110#discussion_r122812132
  
    --- Diff: gora-cassandra-cql/src/test/java/org/apache/gora/cassandra/store/TestCassandraStore.java
---
    @@ -0,0 +1,92 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +/**
    + * Testing class for all standard gora-cassandra functionality.
    + * We extend DataStoreTestBase enabling us to run the entire base test
    + * suite for Gora. 
    + */
    +package org.apache.gora.cassandra.store;
    +
    +import java.io.IOException;
    +
    +import org.apache.gora.cassandra.GoraCassandraTestDriver;
    +import org.apache.gora.examples.generated.Employee;
    +import org.apache.gora.examples.generated.WebPage;
    +import org.apache.gora.store.DataStore;
    +import org.apache.gora.store.DataStoreFactory;
    +import org.apache.gora.store.DataStoreTestBase;
    +import org.apache.hadoop.conf.Configuration;
    +import org.junit.Before;
    +import org.junit.Ignore;
    +
    +/**
    + * Test for CassandraStore.
    + */
    +public class TestCassandraStore extends DataStoreTestBase{
    +
    +  private Configuration conf;
    +
    +  static {
    +    setTestDriver(new GoraCassandraTestDriver());
    +  }
    +
    +  @Before
    +  public void setUp() throws Exception {
    +    super.setUp();
    +  }
    +
    +  public GoraCassandraTestDriver getTestDriver() {
    +    return (GoraCassandraTestDriver) testDriver;
    +  }
    +
    +
    +  @Ignore("GORA-299 o.a.g.cassandra.CassandraStore#newQuery() should not use query.setFields(getFieldsToQuery(null));")
    --- End diff --
    
    Please remove all @ Ignore tags here and make sure that these tests run.. if they do not
run then we need to implement the functionality. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message