gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alfonsonishikawa <...@git.apache.org>
Subject [GitHub] gora pull request #135: Goraexplorer needed changes
Date Thu, 04 Oct 2018 00:17:58 GMT
Github user alfonsonishikawa commented on a diff in the pull request:

    https://github.com/apache/gora/pull/135#discussion_r222506186
  
    --- Diff: gora-compiler/src/main/velocity/org/apache/gora/compiler/templates/record.vm
---
    @@ -180,6 +180,11 @@ public class ${this.mangle($schema.getName())}#if ($schema.isError())
extends or
         return new #if ($schema.getNamespace())$schema.getNamespace().#end${this.mangle($schema.getName())}.Builder(other);
       }
       
    +  @Override
    --- End diff --
    
    A clone method. I used it [here](https://bitbucket.org/alfonsonishikawa/goraexplorer/src/12f226408e7f9686aa6b5975692edf270b94182e/src/main/java/com/nishilua/goraexplorer/tables/TableEntityServiceImpl.java#lines-118)
because `get()` reuses the instance.


---

Mime
View raw message