gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alfonsonishikawa <...@git.apache.org>
Subject [GitHub] gora pull request #135: Goraexplorer needed changes
Date Thu, 04 Oct 2018 00:31:33 GMT
Github user alfonsonishikawa commented on a diff in the pull request:

    https://github.com/apache/gora/pull/135#discussion_r222508076
  
    --- Diff: gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java ---
    @@ -80,15 +81,20 @@
      * DataStore for HBase. Thread safe.
      *
      */
    -public class HBaseStore<K, T extends PersistentBase> extends DataStoreBase<K,
T>
    -implements Configurable {
    +public class HBaseStore<K, T extends PersistentBase> extends DataStoreBase<K,
T> {
     
       public static final Logger LOG = LoggerFactory.getLogger(HBaseStore.class);
     
       public static final String PARSE_MAPPING_FILE_KEY = "gora.hbase.mapping.file";
     
       public static final String DEFAULT_MAPPING_FILE = "gora-hbase-mapping.xml";
     
    +  /**
    +   * Key at DataStore Properties (same as gora.properties) to hold a mapping loaded from
memory, instead from filesystem like
    +   * the one at PARSE_MAPPING_FILE_KEY. If this key is present, the mapping is loaded
from the value instead of gora-hbase-mapping.xml
    +   */
    +  public static final String XML_MAPPING_DEFINITION = "gora.mapping" ;  
    --- End diff --
    
    When creating the DataStore (for HBase!) the Properties can have a key `gora.mapping`
with the XML document of the mapping. If it exists, this mapping is loaded instead of the
file one at `gora-hbase-mapping.xml`.


---

Mime
View raw message