gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lewismc <...@git.apache.org>
Subject [GitHub] gora pull request #135: Goraexplorer needed changes
Date Thu, 04 Oct 2018 05:50:01 GMT
Github user lewismc commented on a diff in the pull request:

    https://github.com/apache/gora/pull/135#discussion_r222541077
  
    --- Diff: gora-compiler/src/main/velocity/org/apache/gora/compiler/templates/record.vm
---
    @@ -180,6 +180,11 @@ public class ${this.mangle($schema.getName())}#if ($schema.isError())
extends or
         return new #if ($schema.getNamespace())$schema.getNamespace().#end${this.mangle($schema.getName())}.Builder(other);
       }
       
    +  @Override
    --- End diff --
    
    You should have referenced line 121 not 118. 


---

Mime
View raw message