gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lewismc <...@git.apache.org>
Subject [GitHub] gora pull request #135: Goraexplorer needed changes
Date Thu, 04 Oct 2018 05:50:06 GMT
Github user lewismc commented on a diff in the pull request:

    https://github.com/apache/gora/pull/135#discussion_r222542415
  
    --- Diff: gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java ---
    @@ -734,14 +756,13 @@ private void setField(T persistent, Field field, List list) {
       }
     
       @SuppressWarnings("unchecked")
    -  private HBaseMapping readMapping(String filename) throws IOException {
    +  private HBaseMapping readMapping(InputStream mappingStream) throws IOException {
    --- End diff --
    
    I like this. The quicker work with ByteStream the better. 


---

Mime
View raw message