gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maria Podorvanova <podorvanova.ma...@gmail.com>
Subject Re: Add datastore for Elasticsearch. Outreachy Week 6 Report
Date Mon, 11 Jan 2021 05:41:46 GMT
Hi,

Thank you for your feedback.

I will define the parameter for the XSD validation and fix authentication.

I submitted my midpoint feedback last week.

Regards,
Maria

On Mon, 11 Jan 2021 at 11:38, John Mora <jhnmora000@gmail.com> wrote:

> Hi.
>
> Thanks for the update.
>
> Some comments:
>
> Please define a parameter for the XSD validation ( gora.xsd_validation, default:
> false )
> Example:
> https://github.com/apache/gora/blob/master/gora-lucene/src/main/java/org/apache/gora/lucene/store/LuceneStore.java#L131
>
> I do not think the Elasticsearch authentication is working. Here, you set
> the username and password to : "gora.datastore.elasticsearch.username" and
> "gora.datastore.elasticsearch.password" (literal values) in the container.
>
> https://github.com/podorvanova/gora/blob/gora-664/gora-elasticsearch/src/test/java/org/apache/gora/elasticsearch/GoraElasticsearchTestDriver.java#L41
>
> But, in the properties file the values are "username" and "password".
>
> https://github.com/podorvanova/gora/blob/gora-664/gora-elasticsearch/src/test/resources/gora.properties#L24
>
> Please do not forget to submit your midpoint feedback. It is due Jan. 12
> 4pm UTC.
>
> Cheers,
> John
>
> El sáb, 9 ene 2021 a las 5:21, Maria Podorvanova (<
> podorvanova.maria@gmail.com>) escribió:
>
>> Hi,
>>
>> Report #6
>> Period: January 3 - January 9
>> Activities:
>> - Added XSD validation file for the XML mapping [1]
>> - Fixed XSD validation [2]
>>
>>    1. Relocated gora-elasticsearch.xsd file to main resources
>>    2. Covered XSD validation with test
>>    3. Added gora-elasticsearch-mapping-invalid.xml file for test
>>
>> - Set up Elasticsearch container's authentication parameters [3]
>> - Implemented exists method [4]
>> - Added comments for the connection parameters [5]
>>
>> Here are links to the commits:
>> [1]
>> https://github.com/apache/gora/commit/5020efc9aaf80c7e585b446bec3be392969093ba
>>
>> [2]
>> https://github.com/apache/gora/commit/05e8ed5ebddfbbddb175a683d0242a76896e6bb5
>>
>> [3]
>> https://github.com/apache/gora/commit/66c9d80ee255df5c3b397aa5b0e4e1256598ebb5
>>
>> [4]
>> https://github.com/apache/gora/commit/2f7d7218d7c120ad4694916186debdab3beac4f7
>>
>> [5]
>> https://github.com/apache/gora/commit/e2d0aeba8db9fd65e6e127d08196e2facac52c05
>>
>>
>> Regards,
>> Maria
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message