hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brahma Reddy Battula <brahmareddy.batt...@hotmail.com>
Subject Re: [DISCUSS] Commit log Pattern Unification
Date Thu, 01 Dec 2016 16:41:42 GMT
Dear All,


 Upon discussion till now , we can choose one of the following option.


a) Contributed XXX.

b) Signoff feature ( which might allow commits with non-apache mail,it might some more discussion)


Whether any vote thread required to conclusion for this..?




Thanks And Regards
Brahma Reddy Battula


________________________________
From: Andrew Wang <andrew.wang@cloudera.com>
Sent: Tuesday, November 22, 2016 10:05 AM
To: Brahma Reddy Battula
Cc: Akira Ajisaka; Allen Wittenauer; Ravi Prakash; common-dev@hadoop.apache.org; Daniel Templeton;
Brahma Reddy Battula
Subject: Re: [DISCUSS] Commit log Pattern Unification

This is a bit of an aside, but if anyone's interested in grepping git log, I've written a
python script that helps with this:

https://github.com/umbrant/versions
[https://avatars1.githubusercontent.com/u/33948?v=3&s=400]<https://github.com/umbrant/versions>

umbrant/versions<https://github.com/umbrant/versions>
github.com
versions - Script for bulk updating JIRAs




This includes a fixup file that patches typo'd commit messages as well as commits that include
multiple JIRAs. The script also detects reverts and merges.

I wrote this to validate the 3.0.0-alpha2 fixversion matches the state in the git repo, and
it found a lot of mistakes. It should be easy to add support for other releases, though someone
would need to go through the errors to make the fixup file.

Best,
Andrew

On Fri, Nov 18, 2016 at 1:08 AM, Brahma Reddy Battula <brahmareddy.battula@huawei.com<mailto:brahmareddy.battula@huawei.com>>
wrote:
Thanks Akira Ajisaka, Ravi Prakash,Andrew wang,Allen Wittenauer and Daniel..

Some are favored for option d ( i.e" contributed by XXX.") and Akira and Allen are suggesting
to use "signed-off-feature" with git-format-patch.

Many other communities, like Yetus,HBase,Spark all are enforcing for git-format-patch, can
we also do this..?

So how to conclude on this..?

Seems to be we can't commit  author as contributor , as Andrew pointed.(contributors will
not having the apache mail-id).

can we recommend contributors to keep consistent email-Id..?

Would like to add one more point ,  "smart-apply-patch" can improve like auto commit to specified
branches , which makes things easier for committer..?



Regards
Brahma Reddy Battula



-----Original Message-----
From: Akira Ajisaka [mailto:ajisakaa@oss.nttdata.co.jp<mailto:ajisakaa@oss.nttdata.co.jp>]
Sent: 08 November 2016 10:05
To: Allen Wittenauer; Ravi Prakash
Cc: Daniel Templeton; Brahma Reddy Battula; common-dev@hadoop.apache.org<mailto:common-dev@hadoop.apache.org>
Subject: Re: [DISCUSS] Commit log Pattern Unification

In more detail, I'm +1 for requiring 'git format-patch' and commit with 'dev-support/bin/smart-apply-patch
--committer', as well as Apache Yetus.

That way committers can use signed-off feature and don't need to add 'contributed by ...'
to commit message by hand.

Thanks,
Akira

On 11/8/16 04:38, Allen Wittenauer wrote:
>
>> On Nov 7, 2016, at 11:29 AM, Ravi Prakash <ravihadoop@gmail.com<mailto:ravihadoop@gmail.com>>
wrote:
>>
>> I have a preference for d) Contributed by XXX.
>>
>> Wouldn't signed-off require the commit to come from the contributor?
>> What about people who submit patch files?
>
>       If the patches are built with 'git format-patch', no.
>
>       In Apache Yetus, we moved to requiring that patch format + committing with 'smart-apply-patch
--committer'.  Makes life much easier, esp when it comes time to see who is actually contributing
patches.
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org<mailto:common-dev-unsubscribe@hadoop.apache.org>
> For additional commands, e-mail: common-dev-help@hadoop.apache.org<mailto:common-dev-help@hadoop.apache.org>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org<mailto:common-dev-unsubscribe@hadoop.apache.org>
For additional commands, e-mail: common-dev-help@hadoop.apache.org<mailto:common-dev-help@hadoop.apache.org>



Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message