hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rich Haase (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-12455) fs.Globber breaks on colon in filename; doesn't use Path's handling for colons
Date Mon, 25 Jan 2016 23:43:40 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-12455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Rich Haase updated HADOOP-12455:
              Labels: trivial  (was: )
       Fix Version/s: 2.9.0
    Target Version/s: 2.9.0
              Status: Patch Available  (was: Open)

One line changed, one assertion added to verify.

> fs.Globber breaks on colon in filename; doesn't use Path's handling for colons
> ------------------------------------------------------------------------------
>                 Key: HADOOP-12455
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12455
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>            Reporter: Daniel Barclay (Drill)
>            Assignee: Rich Haase
>              Labels: trivial
>             Fix For: 2.9.0
> {{org.apache.hadoop.fs.Globber.glob()}} breaks when a searched directory 
> contains a file whose simple name contains a colon.
> The problem seem to be in the code currently at lines 258 and 257 
> [https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Globber.java#L257]:
> {noformat}
> 256:              // Set the child path based on the parent path.
> 257:              child.setPath(new Path(candidate.getPath(),
> 258:                      child.getPath().getName()));
> {noformat}
> That last line should probably be:
> {noformat}
>                       new Path(null, null, child.getPath().getName())));
> {noformat}
> &nbsp;
> The bug in the current code is that:
> 1) {{child.getPath().getName()}} gets the simple name (last segment) of the child {{Path}}
as a _raw_ string (not necessarily the corresponding relative _{{Path}}_ string), and
> 2) that raw string is passed as {{Path(Path, String)}}'s second argument, which takes
a _{{Path}}_ string.
> When that raw string contains a colon (e.g., {{xxx:yyy}}), it looks like a {{Path}} string
that specifies a scheme ("{{xxx}}") and has a relative path "{{yyy}}}"--but that combination
isn't allowed, so trying to constructing a {{Path}} with it (as {{Path(Path, String)}} does
inside) throws an exception, aborting the entire {{glob()}} call.
> &nbsp;
> Adding the call to {{Path(String, String, String)}} does the equivalent of converting
the raw string "{{xxx:yyy}}" to the {{Path}} string "{{./xxx:yyy}}", so the part before the
colon is not taken as a scheme.

This message was sent by Atlassian JIRA

View raw message