hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] ehiggs commented on a change in pull request #575: HADOOP-13327 Output Stream Specification
Date Fri, 15 Mar 2019 10:30:45 GMT
ehiggs commented on a change in pull request #575: HADOOP-13327 Output Stream Specification
URL: https://github.com/apache/hadoop/pull/575#discussion_r265925252
 
 

 ##########
 File path: hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractFSContractTestBase.java
 ##########
 @@ -272,7 +272,7 @@ protected void handleRelaxedException(String action,
     if (getContract().isSupported(SUPPORTS_STRICT_EXCEPTIONS, false)) {
       throw e;
     }
-    LOG.warn("The expected exception {}  was not the exception class" +
+    LOG.warn("The expected exception {} was not the exception class" +
 
 Review comment:
   ```java
       // org.slf4j.Logger
       public void warn(String msg);
       public void warn(String format, Object arg);
       public void warn(String format, Object... arguments); // <-- I think it will choose
this. 
       public void warn(String format, Object arg1, Object arg2);
       public void warn(String format, Object arg1, Object arg2);
       public void warn(String msg, Throwable t);
       public void warn(Marker marker, String msg);
       public void warn(Marker marker, String format, Object arg);
       public void warn(Marker marker, String format, Object arg1, Object arg2);
       public void warn(Marker marker, String format, Object... arguments);
       public void warn(Marker marker, String msg, Throwable t);
   ```
   Maybe in the impl it checks the type to see if it's throwable? 🤷‍♂️ 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message