hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] ajayydv commented on a change in pull request #627: HDDS-1299. Support TokenIssuer interface for running jobs with OzoneFileSystem.
Date Fri, 22 Mar 2019 22:00:54 GMT
ajayydv commented on a change in pull request #627: HDDS-1299. Support TokenIssuer interface
for running jobs with OzoneFileSystem.
URL: https://github.com/apache/hadoop/pull/627#discussion_r268352903
 
 

 ##########
 File path: hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/OzoneClientAdapterImpl.java
 ##########
 @@ -289,7 +291,7 @@ public boolean hasNextKey(String key) {
   @Override
   public Token<OzoneTokenIdentifier> getDelegationToken(String renewer)
       throws IOException {
-    if (!securityEnabled) {
+    if (!securityEnabled || renewer == null) {
 
 Review comment:
   What if a use case don't have a requirement for renewing the token. In that case we should
allow empty/null renewer. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message