hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] aajisaka commented on a change in pull request #1397: MAPREDUCE-7237. Supports config the shuffle's path cache related parameters
Date Wed, 04 Mar 2020 02:31:17 GMT
aajisaka commented on a change in pull request #1397: MAPREDUCE-7237. Supports config the shuffle's
path cache related parameters
URL: https://github.com/apache/hadoop/pull/1397#discussion_r387416495
 
 

 ##########
 File path: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
 ##########
 @@ -1266,6 +1266,29 @@
   </description>
 </property>
 
+<property>
+  <name>mapreduce.shuffle.pathcache.max-weight</name>
+  <value>10 * 1024 * 1024</value>
 
 Review comment:
   Thanks @jiwq for the reply and the update.
   
   One comment: the style cannot be parsed by org.apache.hadoop.conf.Configuration.
   ```suggestion
     <value>10485760</value>
   ```
   
   +1 if that is addressed.
   Sorry I forgot to review for a long time.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message