hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] goiri commented on a change in pull request #1904: HADOOP-16931. reduce the execution time of the TestRolloverSignerSecretProvider
Date Sat, 21 Mar 2020 15:23:05 GMT
goiri commented on a change in pull request #1904: HADOOP-16931. reduce the execution time
of the TestRolloverSignerSecretProvider
URL: https://github.com/apache/hadoop/pull/1904#discussion_r396001301
 
 

 ##########
 File path: hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/util/TestRolloverSignerSecretProvider.java
 ##########
 @@ -52,7 +52,6 @@ public void testGetAndRollSecrets() throws Exception {
       Assert.assertEquals(2, allSecrets.length);
       Assert.assertArrayEquals(secret3, allSecrets[0]);
       Assert.assertArrayEquals(secret2, allSecrets[1]);
-      Thread.sleep(rolloverFrequency + 2000);
 
 Review comment:
   As we are trying to improve this, let's do this test a little more controlled and use wairFor,
etc.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message