hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop] DadanielZ commented on a change in pull request #1898: HADOOP-16852: Report read-ahead error back
Date Sun, 29 Mar 2020 00:22:48 GMT
DadanielZ commented on a change in pull request #1898: HADOOP-16852: Report read-ahead error
back
URL: https://github.com/apache/hadoop/pull/1898#discussion_r399723610
 
 

 ##########
 File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/ReadBufferManager.java
 ##########
 @@ -141,7 +144,8 @@ void queueReadAhead(final AbfsInputStream stream, final long requestedOffset,
fi
    * @param buffer   the buffer to read data into. Note that the buffer will be written into
from offset 0.
    * @return the number of bytes read
    */
-  int getBlock(final AbfsInputStream stream, final long position, final int length, final
byte[] buffer) {
+  int getBlock(final AbfsInputStream stream, final long position, final int length, final
byte[] buffer)
+      throws java.io.IOException {
 
 Review comment:
   why use `java.io.IOException `but not `IOException`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message