hadoop-mapreduce-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sangjin Lee <sj...@apache.org>
Subject Re: HADOOP-13410
Date Wed, 10 Aug 2016 00:42:42 GMT
I just tested a simple service loader with the patch and it works fine even
if the jar is not in the classpath.

On Tue, Aug 9, 2016 at 10:41 AM, Sangjin Lee <sjlee@apache.org> wrote:

> It uses ClassLoader.getResources() so there shouldn't be anything specific
> to the form of the resource (jar or not). But I'll test it later.
>
> On Tue, Aug 9, 2016 at 9:06 AM, Sean Busbey <busbey@cloudera.com> wrote:
>
>> ServiceLoader API stuff won't load out of the unpacked version, right?
>>
>> On Tue, Aug 9, 2016 at 11:00 AM, Sangjin Lee <sjlee@apache.org> wrote:
>> > I'd like to get feedback from the community (especially those who might
>> > remember this) on HADOOP-13410:
>> > https://issues.apache.org/jira/browse/HADOOP-13410
>> >
>> > It appears that Hadoop's RunJar adds the original jar to the app's
>> > classpath even though the unjarred contents of the jar are in the
>> > classpath. As long as the file is a jar (or its variant), this seems
>> > completely superfluous. My suspicion is that the line of code that adds
>> the
>> > jar to the classpath may have been left there by accident.
>> >
>> > Could anyone confirm this? Does anyone see an issue with removing the
>> jar
>> > from the classpath? I've tested the fix with a couple of simple apps,
>> and I
>> > didn't see a problem.
>> >
>> > Thanks,
>> > Sangjin
>>
>>
>>
>> --
>> busbey
>>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message