hadoop-mapreduce-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steve Loughran <ste...@hortonworks.com>
Subject Re: [VOTE] Merge HADOOP-13341
Date Fri, 09 Sep 2016 10:31:27 GMT

> On 8 Sep 2016, at 16:08, Allen Wittenauer <aw@effectivemachines.com> wrote:
> 
> 
>> On Sep 8, 2016, at 2:50 AM, Steve Loughran <stevel@hortonworks.com> wrote:
>> 
>> I'm trying to do the review effort here even though I don't know detailed bash, as
I expect I don't know any less than others, and what better way to learn than reviewing code
written by people that do know bash? 
> 
> 	Just a heads up that I'm using bash variable references. While not exactly rare, they
are uncommon.   [We use them in lots of places in the shell code already, so no new ground
being broken.]  
> 
>> Could you submit a PR of that HADOOP-13341 branch, so I can review it there.
> 
> 	Sure.  https://github.com/apache/hadoop/pull/126 has been opened.
> 
> 	Thanks!

LGTM: +1. Added the vote on the JIRA too

---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-dev-help@hadoop.apache.org


Mime
View raw message