hadoop-yarn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vivek Ratnavel <vivekratna...@apache.org>
Subject Re: [DISCUSS] Change project style guidelines to allow line length 100
Date Thu, 20 May 2021 18:29:47 GMT
+1 (non-binding) to increase line length to 100 characters. This will
definitely help clear most of the checkstyle violations.

Thank you Sean for starting this thread!

On Thu, May 20, 2021 at 7:17 AM Sean Busbey <sbusbey@apple.com.invalid>
wrote:

> Hi Bhavik!
>
> What concerns do you have about back porting patches to earlier release
> branches?
>
> If we change our style guidelines then presumably we can do that for all
> branches, so a backport from e.g. trunk to branch-3.3 won’t fail a style
> check on the destination branch unless something changed in the backporting.
>
> If you are referring to patches for clearing up line length violations, my
> usual preference is to aim for my changes to be on all active release
> lines. So at least in the case of the patches coming from me or being
> committed by me, there’d be effort to make sure all branches end up as easy
> to backport to as they were prior to the clean up.
>
>
>
> > On May 20, 2021, at 2:27 AM, Bhavik Patel <bhavikpatel552@gmail.com>
> wrote:
> >
> > I am just worried about the backporting of the Jira to child branch!! How
> > we are planning to handle this?
> >
> > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684824@qq.com <mailto:
> 821684824@qq.com>> wrote:
> >
> >> +1 100 is reasonable.
> >>
> >>
> >>
> >> ---Original---
> >> From: "Xiaoqiao He"<hexiaoqiao@apache.org <mailto:hexiaoqiao@apache.org
> >&gt;
> >> Date: Thu, May 20, 2021 13:35 PM
> >> To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp <mailto:
> iwasakims@oss.nttdata.co.jp>&gt;;
> >> Cc: "Akira Ajisaka"<aajisaka@apache.org <mailto:aajisaka@apache.org>&gt;;"Hadoop
> Common"<
> >> common-dev@hadoop.apache.org <mailto:common-dev@hadoop.apache.org
> >&gt;;"Hdfs-dev"<hdfs-dev@hadoop.apache.org <mailto:
> hdfs-dev@hadoop.apache.org>
> >> &gt;;"yarn-dev"<yarn-dev@hadoop.apache.org <mailto:
> yarn-dev@hadoop.apache.org>&gt;;"mapreduce-dev"<
> >> mapreduce-dev@hadoop.apache.org <mailto:mapreduce-dev@hadoop.apache.org
> >&gt;;
> >> Subject: Re: [DISCUSS] Change project style guidelines to allow line
> >> length 100
> >>
> >>
> >> +1 for <= 100 chars long per line length.
> >>
> >> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> >> iwasakims@oss.nttdata.co.jp&gt; wrote:
> >>
> >> &gt; I'm +1 too.
> >> &gt; I feel 80 characters limit tends to degrade readability by
> introducing
> >> &gt; useless line breaks.
> >> &gt;
> >> &gt; &gt;
> >> &gt;
> >>
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> >> &gt
> >> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E&gt
> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E&gt
> >>
> >> ;
> >> &gt; I have no inconvenience on 100 characters for using Emacs and
> >> side-by-side
> >> &gt; diff even on 13-inch MBP.
> >> &gt;
> >> &gt; Masatake Iwasaki
> >> &gt;
> >> &gt; On 2021/05/20 11:00, Akira Ajisaka wrote:
> >> &gt; &gt; I'm +1 to allow <= 100 chars.
> >> &gt; &gt;
> >> &gt; &gt; FYI: There were some discussions long before:
> >> &gt; &gt; -
> >> &gt;
> >>
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> >> &gt
> >> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E&gt
> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E&gt
> >>;
> >> &gt; -
> >> &gt;
> >>
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> <
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> >> &gt
> >> <
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E&gt
> <
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E&gt
> >>;
> >> &gt;
> >> &gt; &gt; Thanks,
> >> &gt; &gt; Akira
> >> &gt; &gt;
> >> &gt; &gt; On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> >> <sbusbey@apple.com.invalid <mailto:sbusbey@apple.com.invalid>&gt;
> >> &gt; wrote:
> >> &gt; &gt;&gt;
> >> &gt; &gt;&gt; Hello!
> >> &gt; &gt;&gt;
> >> &gt; &gt;&gt; What do folks think about changing our line length
> >> guidelines to allow
> >> &gt; for 100 character width?
> >> &gt; &gt;&gt;
> >> &gt; &gt;&gt; Currently, we tell folks to follow the sun style guide
> with
> >> some
> >> &gt; exception unrelated to line length. That guide says width of 80 is
> the
> >> &gt; standard and our current check style rules act as enforcement.
> >> &gt; &gt;&gt;
> >> &gt; &gt;&gt; Looking at the current trunk codebase our nightly
build
> >> shows a total
> >> &gt; of ~15k line length violations; it’s about 18% of identified
> >> checkstyle
> >> &gt; issues.
> >> &gt; &gt;&gt;
> >> &gt; &gt;&gt; The vast majority of those line length violations
are <=
> 100
> >> characters
> >> &gt; long. 100 characters happens to be the length for the Google Java
> >> Style
> >> &gt; Guide, another commonly adopted style guide for java projects, so I
> >> suspect
> >> &gt; these longer lines leaking past the checkstyle precommit warning
> >> might be a
> >> &gt; reflection of committers working across multiple java codebases.
> >> &gt; &gt;&gt;
> >> &gt; &gt;&gt; I don’t feel strongly about lines being longer,
but I
> would
> >> like to
> >> &gt; move towards more consistent style enforcement as a project.
> Updating
> >> our
> >> &gt; project guidance to allow for 100 character lines would reduce the
> >> &gt; likelihood that folks bringing in new contributions need a
> precommit
> >> test
> >> &gt; cycle to get the formatting correct.
> >> &gt; &gt;&gt;
> >> &gt; &gt;&gt; Does anyone feel strongly about keeping the line length
> >> limit at 80
> >> &gt; characters?
> >> &gt; &gt;&gt;
> >> &gt; &gt;&gt; Does anyone feel strongly about contributions coming
in
> that
> >> clear up
> >> &gt; line length violations?
> >> &gt; &gt;&gt;
> >> &gt; &gt;&gt;
> >> &gt; &gt;&gt;
> >> ---------------------------------------------------------------------
> >> &gt; &gt;&gt; To unsubscribe, e-mail:
> >> common-dev-unsubscribe@hadoop.apache.org <mailto:
> common-dev-unsubscribe@hadoop.apache.org>
> >> &gt; &gt;&gt; For additional commands, e-mail:
> >> common-dev-help@hadoop.apache.org <mailto:
> common-dev-help@hadoop.apache.org>
> >> &gt; &gt;&gt;
> >> &gt; &gt;
> >> &gt; &gt;
> >> ---------------------------------------------------------------------
> >> &gt; &gt; To unsubscribe, e-mail:
> common-dev-unsubscribe@hadoop.apache.org <mailto:
> common-dev-unsubscribe@hadoop.apache.org>
> >> &gt; &gt; For additional commands, e-mail:
> >> common-dev-help@hadoop.apache.org <mailto:
> common-dev-help@hadoop.apache.org>
> >> &gt; &gt;
> >> &gt;
> >> &gt;
> ---------------------------------------------------------------------
> >> &gt; To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> <mailto:common-dev-unsubscribe@hadoop.apache.org>
> >> &gt; For additional commands, e-mail: common-dev-help@hadoop.apache.org
> <mailto:common-dev-help@hadoop.apache.org>
> >> &gt;
> >> &gt;
>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message