hadoop-yarn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Viraj Jasani <vjas...@apache.org>
Subject Re: [DISCUSS] Change project style guidelines to allow line length 100
Date Thu, 20 May 2021 11:03:23 GMT
+1 (non-binding) to increasing line length to 100 instead of 80 and
applying this to all active branches (for the ease of backport as Stephen
mentioned).


On Thu, 20 May 2021 at 3:30 PM, Stephen O'Donnell
<sodonnell@cloudera.com.invalid> wrote:

> I am +1 on increasing the line length to 100.
>
> As for changes to address existing style issues - I think that is more pain
> than it's worth. It will make backports much harder, and we have quite a
> few active branches, not to mention those who maintain custom builds.
>
> To ease the backport problems the style fixes would need to be pushed down
> all the branches, otherwise if we start making them on trunk only, future
> changes on trunk will not be able to be cherry-picked cleanly to branch-3.3
> etc.
>
>
> On Thu, May 20, 2021 at 8:28 AM Bhavik Patel <bhavikpatel552@gmail.com>
> wrote:
>
> > I am just worried about the backporting of the Jira to child branch!! How
> > we are planning to handle this?
> >
> > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684824@qq.com> wrote:
> >
> > > +1 100 is reasonable.
> > >
> > >
> > >
> > > ---Original---
> > > From: "Xiaoqiao He"<hexiaoqiao@apache.org&gt;
> > > Date: Thu, May 20, 2021 13:35 PM
> > > To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp&gt;;
> > > Cc: "Akira Ajisaka"<aajisaka@apache.org&gt;;"Hadoop Common"<
> > > common-dev@hadoop.apache.org&gt;;"Hdfs-dev"<hdfs-dev@hadoop.apache.org
> > > &gt;;"yarn-dev"<yarn-dev@hadoop.apache.org&gt;;"mapreduce-dev"<
> > > mapreduce-dev@hadoop.apache.org&gt;;
> > > Subject: Re: [DISCUSS] Change project style guidelines to allow line
> > > length 100
> > >
> > >
> > > +1 for <= 100 chars long per line length.
> > >
> > > On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> > > iwasakims@oss.nttdata.co.jp&gt; wrote:
> > >
> > > &gt; I'm +1 too.
> > > &gt; I feel 80 characters limit tends to degrade readability by
> > introducing
> > > &gt; useless line breaks.
> > > &gt;
> > > &gt; &gt;
> > > &gt;
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > &gt
> > > <
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E&gt
> > >
> > > ;
> > > &gt; I have no inconvenience on 100 characters for using Emacs and
> > > side-by-side
> > > &gt; diff even on 13-inch MBP.
> > > &gt;
> > > &gt; Masatake Iwasaki
> > > &gt;
> > > &gt; On 2021/05/20 11:00, Akira Ajisaka wrote:
> > > &gt; &gt; I'm +1 to allow <= 100 chars.
> > > &gt; &gt;
> > > &gt; &gt; FYI: There were some discussions long before:
> > > &gt; &gt; -
> > > &gt;
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > &gt
> > > <
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E&gt
> > >;
> > > &gt; -
> > > &gt;
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > &gt
> > > <
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E&gt
> > >;
> > > &gt;
> > > &gt; &gt; Thanks,
> > > &gt; &gt; Akira
> > > &gt; &gt;
> > > &gt; &gt; On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> > > <sbusbey@apple.com.invalid&gt;
> > > &gt; wrote:
> > > &gt; &gt;&gt;
> > > &gt; &gt;&gt; Hello!
> > > &gt; &gt;&gt;
> > > &gt; &gt;&gt; What do folks think about changing our line length
> > > guidelines to allow
> > > &gt; for 100 character width?
> > > &gt; &gt;&gt;
> > > &gt; &gt;&gt; Currently, we tell folks to follow the sun style
guide
> with
> > > some
> > > &gt; exception unrelated to line length. That guide says width of 80 is
> > the
> > > &gt; standard and our current check style rules act as enforcement.
> > > &gt; &gt;&gt;
> > > &gt; &gt;&gt; Looking at the current trunk codebase our nightly
build
> > > shows a total
> > > &gt; of ~15k line length violations; it’s about 18% of identified
> > > checkstyle
> > > &gt; issues.
> > > &gt; &gt;&gt;
> > > &gt; &gt;&gt; The vast majority of those line length violations
are <=
> > 100
> > > characters
> > > &gt; long. 100 characters happens to be the length for the Google Java
> > > Style
> > > &gt; Guide, another commonly adopted style guide for java projects, so
> I
> > > suspect
> > > &gt; these longer lines leaking past the checkstyle precommit warning
> > > might be a
> > > &gt; reflection of committers working across multiple java codebases.
> > > &gt; &gt;&gt;
> > > &gt; &gt;&gt; I don’t feel strongly about lines being longer,
but I
> would
> > > like to
> > > &gt; move towards more consistent style enforcement as a project.
> > Updating
> > > our
> > > &gt; project guidance to allow for 100 character lines would reduce the
> > > &gt; likelihood that folks bringing in new contributions need a
> precommit
> > > test
> > > &gt; cycle to get the formatting correct.
> > > &gt; &gt;&gt;
> > > &gt; &gt;&gt; Does anyone feel strongly about keeping the line
length
> > > limit at 80
> > > &gt; characters?
> > > &gt; &gt;&gt;
> > > &gt; &gt;&gt; Does anyone feel strongly about contributions coming
in
> > that
> > > clear up
> > > &gt; line length violations?
> > > &gt; &gt;&gt;
> > > &gt; &gt;&gt;
> > > &gt; &gt;&gt;
> > > ---------------------------------------------------------------------
> > > &gt; &gt;&gt; To unsubscribe, e-mail:
> > > common-dev-unsubscribe@hadoop.apache.org
> > > &gt; &gt;&gt; For additional commands, e-mail:
> > > common-dev-help@hadoop.apache.org
> > > &gt; &gt;&gt;
> > > &gt; &gt;
> > > &gt; &gt;
> > > ---------------------------------------------------------------------
> > > &gt; &gt; To unsubscribe, e-mail:
> > common-dev-unsubscribe@hadoop.apache.org
> > > &gt; &gt; For additional commands, e-mail:
> > > common-dev-help@hadoop.apache.org
> > > &gt; &gt;
> > > &gt;
> > > &gt;
> > ---------------------------------------------------------------------
> > > &gt; To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> > > &gt; For additional commands, e-mail:
> common-dev-help@hadoop.apache.org
> > > &gt;
> > > &gt;
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message