helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinayak Borkar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HELIX-73) Remove assumption that Instance.id is always host_port
Date Tue, 02 Apr 2013 08:43:16 GMT

    [ https://issues.apache.org/jira/browse/HELIX-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619626#comment-13619626
] 

Vinayak Borkar commented on HELIX-73:
-------------------------------------

The way it stands right now in the code there are lots of places where it is assumed that:

instance.id = f(instance.hostname, instance.port)

where f is invertible.

To fix this issue (part 1), I am planning to eliminate the connection between and instance
id and the host and port duo. As a first step, the host and port will have to be explicitly
set in the InstanceConfig object when an Instance is added, IN ADDITION to the ID. The code
that creates an InstanceConfig programmatically is free to follow any convention to set the
three values (id, host, port), but Helix itself will not assume that one is computable from
the other.

As the next step (part 2), I would like to change the host, port values to be session specific
-- When an instance actually is connected to Helix, is when it gets to specify its host and
port. This would allow an instance to be constructed / added just with an Id, but the host
and port could be selected dynamically. This change seems to be related to the request in

https://issues.apache.org/jira/browse/HELIX-19.

I am looking for feedback on part 1 before I attach patches.
                
> Remove assumption that Instance.id is always host_port
> ------------------------------------------------------
>
>                 Key: HELIX-73
>                 URL: https://issues.apache.org/jira/browse/HELIX-73
>             Project: Apache Helix
>          Issue Type: Improvement
>          Components: helix-core
>    Affects Versions: 0.6.0-incubating
>            Reporter: Vinayak Borkar
>             Fix For: 0.6.1-incubating
>
>
> Currently, some parts of Helix make an assumption that the id of an Instance is always
made up of a combination of host and port. Can this assumption be eliminated? If so, I can
work on providing a patch that fixes this issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message