helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Max Calderoni (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HELIX-77) Skip tests in default build or separate unit/integration tests
Date Fri, 05 Apr 2013 19:51:16 GMT

    [ https://issues.apache.org/jira/browse/HELIX-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13623998#comment-13623998

Max Calderoni commented on HELIX-77:

Sorry, just realized patch is already applied - message was from Hudson.
Ok, please let me know how to go about this based on my prev comments/questions.

Please note that with my change in place, in order to run the build on Hudson as before, Hudson
*needs to run*:
mvn clean install -P integration-test
The previous command alone:
mvn clean install
will *not* run any tests under a directory containing a folder named "integration".
> Skip tests in default build or separate unit/integration tests
> --------------------------------------------------------------
>                 Key: HELIX-77
>                 URL: https://issues.apache.org/jira/browse/HELIX-77
>             Project: Apache Helix
>          Issue Type: Improvement
>            Reporter: Max Calderoni
>            Priority: Minor
>         Attachments: cleanupsNew.diff, cleanups.patch, helix-77.patch, patchBoth.diff,
separateintegtestsNew.diff, separateintegtests.patch
> A couple of miscellaneous questions about how you require building helix.
> Would it be possible to skip tests by default in your pom?
> Normally, after cloning sources (for experimenting/browsing), you would do:
> mvn clean install
> which for helix should take maybe 10-30 seconds.
> Because you have tests turned on by default the build takes much much longer (it looks
like there are integration tests in the mix, not only fast unit tests).
> I think it would be more usable for people doing 'mvn clean install' rather than the
more verbose:
> mvn clean install -Dmaven.test.skip.exec=true
> Attaching a patch that shows what i mean in the pom.
> The other related question is about integration tests. The reason why takes so long to
build is maybe because not all tests being run are unit tests.
> Sometimes there is no clear distinction between integration and unit tests, but the point
is that the build should be fast, so one way to distinguish, arguably, is that if a test is
slow is not a unit test.
> I can show one way of separating unit and integration tests in Maven (Maven does not
have very good support for this, there are different ways to work around it) in a later post
to this. Please let me know if there is any interest in correcting this.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message