helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kanak Biscuitwala (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (HELIX-448) Call onCallback for CustomCodeCallbackHandler for FINALIZE type
Date Wed, 28 May 2014 23:20:01 GMT

     [ https://issues.apache.org/jira/browse/HELIX-448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Kanak Biscuitwala resolved HELIX-448.

    Resolution: Fixed

Fixed. Review: https://reviews.apache.org/r/21993/

For now, onCallback will be invoked for any callback type, and the user should check the type
for appropriate handling.

> Call onCallback for CustomCodeCallbackHandler for FINALIZE type
> ---------------------------------------------------------------
>                 Key: HELIX-448
>                 URL: https://issues.apache.org/jira/browse/HELIX-448
>             Project: Apache Helix
>          Issue Type: Bug
>            Reporter: Kanak Biscuitwala
>            Assignee: Kanak Biscuitwala
> Many use cases assume that onCallback will be invoked with type FINALIZE when leadership
is lost so that there is an opportunity to clean up. However, this is not the case, and the
previous leader has no idea that it's not leader anymore.
> Long term the right thing to do is to split onCallback into 3 different methods, but
for now, we should also invoke onCallback with the appropriate type, since this seems to be
the expected behavior.

This message was sent by Atlassian JIRA

View raw message