helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kanak Biscuitwala (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HELIX-342) Set info field in current-state only if it's not empty
Date Tue, 05 Aug 2014 17:42:14 GMT

    [ https://issues.apache.org/jira/browse/HELIX-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086525#comment-14086525
] 

Kanak Biscuitwala commented on HELIX-342:
-----------------------------------------

This may not be a big deal because it's just an added simple field to a delta that is already
updated with ZK on every state transition. So the added latency is just the CPU time of setting
that simple field. We can leave this open, but if we actually want to do this, we would need
to separate set to null from actually removing the info field.

> Set info field in current-state only if it's not empty
> ------------------------------------------------------
>
>                 Key: HELIX-342
>                 URL: https://issues.apache.org/jira/browse/HELIX-342
>             Project: Apache Helix
>          Issue Type: Sub-task
>            Reporter: Zhen Zhang
>            Assignee: Zhen Zhang
>
> task framework uses an additional info field in the current-state. the default value
is an empty string. we may not set it if it is empty.
> In HelixStateTransitionHandler#postHandleMessage()
> _currentStateDelta.setInfo(partitionId, taskResult.getInfo());
> this is a perf concern instead of correctness



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message