helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HELIX-524) add getProgress() to Task interface
Date Thu, 09 Oct 2014 00:32:34 GMT

    [ https://issues.apache.org/jira/browse/HELIX-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14164469#comment-14164469
] 

ASF GitHub Bot commented on HELIX-524:
--------------------------------------

Github user kanakb commented on the pull request:

    https://github.com/apache/helix/pull/6#issuecomment-58448716
  
    Since this is an open source project, the real answer to this question is "I don't know."
We've made two public releases with this change, and so if there is anyone who has integrated
or is planning to integrate with the task framework, they would need to made a change.
    
    If `ProgressReportingTask` handles the JMX reporting itself (it's an abstract class, not
an interface), then `TaskRunner` wouldn't need to care about progress at all.
    
    And back to the "bogus" return value discussion, I think customers who don't have a good
sense of progress shouldn't be required to change their integration just to implement `getProgress()`.


> add getProgress() to Task interface
> -----------------------------------
>
>                 Key: HELIX-524
>                 URL: https://issues.apache.org/jira/browse/HELIX-524
>             Project: Apache Helix
>          Issue Type: Improvement
>          Components: helix-core
>    Affects Versions: 0.6.4
>            Reporter: Hongbo Zeng
>             Fix For: 0.6.5
>
>
> Add a getProgress to the Task interface, this is very helpful for long running tasks,
from which we know the status of a task and see if it's blocked. The return value is a double,
ranging from 0 to 1.0, 1.0 indicates a task is finished



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message