helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HELIX-636) JobQueue capacity is full due to job not cleaned up
Date Tue, 25 Oct 2016 01:08:58 GMT

    [ https://issues.apache.org/jira/browse/HELIX-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15603790#comment-15603790
] 

ASF GitHub Bot commented on HELIX-636:
--------------------------------------

Github user lei-xia commented on a diff in the pull request:

    https://github.com/apache/helix/pull/55#discussion_r84815009
  
    --- Diff: helix-core/src/test/java/org/apache/helix/integration/task/TestJobQueueCleanUp.java
---
    @@ -0,0 +1,58 @@
    +package org.apache.helix.integration.task;
    +
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +import org.apache.helix.TestHelper;
    +import org.apache.helix.task.JobConfig;
    +import org.apache.helix.task.JobQueue;
    +import org.apache.helix.task.TaskState;
    +import org.apache.helix.task.TaskUtil;
    +import org.testng.Assert;
    +import org.testng.annotations.BeforeClass;
    +import org.testng.annotations.Test;
    +
    +import com.google.common.collect.ImmutableMap;
    +
    +public class TestJobQueueCleanUp extends TaskTestBase {
    --- End diff --
    
    let us use removeJobContext() in the taskUtil?


> JobQueue capacity is full due to job not cleaned up
> ---------------------------------------------------
>
>                 Key: HELIX-636
>                 URL: https://issues.apache.org/jira/browse/HELIX-636
>             Project: Apache Helix
>          Issue Type: Bug
>          Components: helix-core
>    Affects Versions: 0.6.4
>            Reporter: Junkai Xue
>            Assignee: Junkai Xue
>             Fix For: 0.6.x
>
>
> Since JobQueue never cleans up the jobs in the final stage (FAILED, COMPLETED, ABORTED),
JobQueue will reach the capacity limit when jobs keep adding in.
> Fix: Current fix will be adding an API in TaskDriver to clean up the final statge.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message