helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HELIX-662) Page does not render properly when using HTTPS
Date Wed, 16 Aug 2017 23:52:00 GMT

    [ https://issues.apache.org/jira/browse/HELIX-662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129633#comment-16129633
] 

ASF GitHub Bot commented on HELIX-662:
--------------------------------------

GitHub user hivivo opened a pull request:

    https://github.com/apache/helix/pull/105

    [HELIX-662] Fix styling issue when visiting sites with HTTPS protocol

    When user is trying to visit helix site or docs using https protocol, the external styling
files and scripts are not allowed to load into browser by default browser security limitation
since the reflow-maven-skin plugin is using http CDN urls. 
    
    According to the documents here:  http://andriusvelykis.github.io/reflow-maven-skin/skin/resources.html
The fix is to use local downloaded version of css and js files instead.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hivivo/helix master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/helix/pull/105.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #105
    
----
commit 50d65774fa2b741d156b37f7178cce07e2de66fc
Author: Vivo Xu <vxu@linkedin.com>
Date:   2017-08-16T23:39:44Z

    Fix styling issue when visiting sites with HTTPS protocol

----


> Page does not render properly when using HTTPS
> ----------------------------------------------
>
>                 Key: HELIX-662
>                 URL: https://issues.apache.org/jira/browse/HELIX-662
>             Project: Apache Helix
>          Issue Type: Bug
>         Environment: https://helix.apache.org/
>            Reporter: Sebb
>
> The website looks very messy when viewed using https.
> This is because several of the css and js files are unconditionally loaded via http:
even if the main page was loaded using https:. Such mixed content is not allowed by many browsers.
> Either such URLs should always use https, or they should use the same as the page that
loads them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message