helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From l...@apache.org
Subject [1/2] helix git commit: [HELIX-678] Don't clear event queues when the controller is no longer leader.
Date Wed, 14 Mar 2018 17:03:31 GMT
Repository: helix
Updated Branches:
  refs/heads/master b6fd8cb83 -> b5c72bc16


[HELIX-678] Don't clear event queues when the controller is no longer leader.

Cleaning queues is optional for controller state change. However, it may cause potential issue
if the controller state read fails for a short while. As a result, the event will be lost.
So undo this change for safe.


Project: http://git-wip-us.apache.org/repos/asf/helix/repo
Commit: http://git-wip-us.apache.org/repos/asf/helix/commit/b5c72bc1
Tree: http://git-wip-us.apache.org/repos/asf/helix/tree/b5c72bc1
Diff: http://git-wip-us.apache.org/repos/asf/helix/diff/b5c72bc1

Branch: refs/heads/master
Commit: b5c72bc164e8be8155c6108cb8d4567122aafd12
Parents: 7e011d3
Author: Jiajun Wang <jjwang@linkedin.com>
Authored: Wed Feb 7 15:28:49 2018 -0800
Committer: jiajunwang <ericwang1985@gmail.com>
Committed: Tue Mar 13 15:57:07 2018 -0700

----------------------------------------------------------------------
 .../java/org/apache/helix/controller/GenericHelixController.java   | 2 --
 1 file changed, 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/helix/blob/b5c72bc1/helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
----------------------------------------------------------------------
diff --git a/helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
b/helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
index 8109a10..f2709a6 100644
--- a/helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
+++ b/helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
@@ -607,8 +607,6 @@ public class GenericHelixController implements IdealStateChangeListener,
       enableClusterStatusMonitor(true);
       _clusterStatusMonitor.setEnabled(!_paused);
     } else {
-      _eventQueue.clear();
-      _taskEventQueue.clear();
       enableClusterStatusMonitor(false);
     }
 


Mime
View raw message