helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HELIX-675) Cluster Monitor may not be closed or init correctly when leadership changes
Date Fri, 09 Mar 2018 00:57:00 GMT

    [ https://issues.apache.org/jira/browse/HELIX-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392193#comment-16392193
] 

ASF GitHub Bot commented on HELIX-675:
--------------------------------------

GitHub user jiajunwang opened a pull request:

    https://github.com/apache/helix/pull/142

    [HELIX-675] Refactor controller start/cleanup logic to ensure monitor…

    … register/reset is handled in any event orders.
    
    Due to different possible event process order, controller init event might be processed
later or earlier than expected.
    This cause inconsistency when even handler thread process and record information in the
cluster monitor.
    This change ensures cluster monitor is off when the leadership changes to other node.
So no extra metric data will be generated.
    
    Also upgrade related test cases to verify MBean counts.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jiajunwang/helix helix-675

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/helix/pull/142.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #142
    
----
commit f5017c35d2971bb8a5de7b8defca77c0ffdd13bb
Author: jiajunwang <ericwang1985@...>
Date:   2018-03-09T00:51:37Z

    [HELIX-675] Refactor controller start/cleanup logic to ensure monitor register/reset is
handled in any event orders.
    
    Due to different possible event process order, controller init event might be processed
later or earlier than expected.
    This cause inconsistency when even handler thread process and record information in the
cluster monitor.
    This change ensures cluster monitor is off when the leadership changes to other node.
So no extra metric data will be generated.
    
    Also upgrade related test cases to verify MBean counts.

----


> Cluster Monitor may not be closed or init correctly when leadership changes
> ---------------------------------------------------------------------------
>
>                 Key: HELIX-675
>                 URL: https://issues.apache.org/jira/browse/HELIX-675
>             Project: Apache Helix
>          Issue Type: Task
>            Reporter: Jiajun Wang
>            Assignee: Jiajun Wang
>            Priority: Major
>
> Due to different possible event process order, controller init event might be processed
later or earlier than expected.
> This cause inconsistency when even handler thread process and record information in the
cluster monitor.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message