helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HELIX-679) Consolidated behaviors for deleteRecursive and deleteRecursively in ZkClient
Date Tue, 20 Mar 2018 00:20:00 GMT

    [ https://issues.apache.org/jira/browse/HELIX-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405634#comment-16405634
] 

Hudson commented on HELIX-679:
------------------------------

FAILURE: Integrated in Jenkins build helix #1414 (See [https://builds.apache.org/job/helix/1414/])
[HELIX-679] consolidate semantics of recursively delete path in ZkClient (zhan849: rev 0e849035379a04b079ac1274bb8aaab473df1572)
* (edit) helix-core/src/test/java/org/apache/helix/integration/task/TestJobTimeoutTaskNotStarted.java
* (edit) helix-core/src/test/java/org/apache/helix/manager/zk/TestZkBaseDataAccessor.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/TestClusterStartsup.java
* (edit) helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ZkChildResource.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/common/ZkStandAloneCMTestBase.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/TestDriver.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/rebalancer/CrushRebalancers/TestCrushAutoRebalanceNonRack.java
* (edit) helix-core/src/test/java/org/apache/helix/manager/zk/TestZkClusterManager.java
* (edit) helix-core/src/test/java/org/apache/helix/TestHelper.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/task/TestJobFailureHighThreshold.java
* (edit) helix-core/src/main/java/org/apache/helix/manager/zk/zookeeper/ZkClient.java
* (edit) helix-core/src/test/java/org/apache/helix/manager/zk/TestZkClient.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/task/TestJobTimeout.java
* (edit) helix-core/src/test/java/org/apache/helix/participant/TestDistControllerStateModel.java
* (edit) helix-core/src/test/java/org/apache/helix/store/zk/TestZkHelixPropertyStore.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/task/TestGenericTaskAssignmentCalculator.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/TestDisableExternalView.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/TestAddClusterV2.java
* (edit) helix-core/src/test/java/org/apache/helix/manager/zk/TestZkHelixAdmin.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/paticipant/TestStateTransitionTimeoutWithResource.java
* (edit) helix-core/src/test/java/org/apache/helix/participant/TestDistControllerElection.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/rebalancer/TestAutoRebalance.java
* (edit) helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ZkPathResource.java
* (edit) helix-core/src/test/java/org/apache/helix/manager/zk/TestZKUtil.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/paticipant/TestStateTransitionTimeout.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/task/TestUserContentStore.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/task/TestRebalanceRunningTask.java
* (edit) helix-core/src/test/java/org/apache/helix/TestHierarchicalDataStore.java
* (edit) helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManager.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/rebalancer/DelayedAutoRebalancer/TestDelayedAutoRebalanceWithRackaware.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/TestStateTransitionCancellation.java
* (edit) helix-core/src/main/java/org/apache/helix/tools/ZKDumper.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/task/TestJobFailure.java
* (edit) helix-core/src/test/java/org/apache/helix/tools/TestClusterSetup.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/rebalancer/TestAutoRebalancePartitionLimit.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/task/TestIndependentTaskRebalancer.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/task/TestJobFailureTaskNotStarted.java
* (edit) helix-core/src/test/java/org/apache/helix/TestZKCallback.java
* (edit) helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java
* (edit) helix-core/src/test/java/org/apache/helix/task/TestSemiAutoStateTransition.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/TestPartitionMovementThrottle.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/rebalancer/TestZeroReplicaAvoidance.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/rebalancer/CrushRebalancers/TestCrushAutoRebalance.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/rebalancer/TestMixedModeAutoRebalance.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/paticipant/TestNonOfflineInitState.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/TestRebalancerPersistAssignments.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/rebalancer/TestSemiAutoRebalance.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/rebalancer/TestClusterInMaintenanceModeWhenReachingOfflineInstancesLimit.java
* (edit) helix-core/src/test/java/org/apache/helix/task/TaskSynchronizedTestBase.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/TestZkConnectionLost.java
* (edit) helix-core/src/test/java/org/apache/helix/TestZnodeModify.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/rebalancer/DelayedAutoRebalancer/TestDelayedAutoRebalance.java
* (edit) helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/TestAlertingRebalancerFailure.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/rebalancer/CrushRebalancers/TestCrushAutoRebalanceTopoplogyAwareDisabled.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/rebalancer/TestClusterInMaintenanceModeWhenReachingMaxPartition.java
* (edit) helix-core/src/test/java/org/apache/helix/manager/zk/TestZKLiveInstanceData.java


> Consolidated behaviors for deleteRecursive and deleteRecursively in ZkClient
> ----------------------------------------------------------------------------
>
>                 Key: HELIX-679
>                 URL: https://issues.apache.org/jira/browse/HELIX-679
>             Project: Apache Helix
>          Issue Type: Bug
>          Components: helix-core
>            Reporter: Hao Zhang
>            Priority: Major
>
> According to it's documentation `deleteRecursive()` should return true if operation
is successful else false. But the semantics of the base function (`delete()`) it calls is
different: it returns true if operation is successful, returns false if node does not exist,
throws exception upon other errors, and therefore `deleteRecursive()` will also throw exception,
and will return false if any sub-path is deleted already, which is confusing
> To consolidate semantics, we should either have the function only return true/false
or only throw exception upon error.
>  
> Also, to make change backward compatible, I'd propose the following change:
>  # deleteRecursive() will only return true/false, and will not throw exception. If subpath
does not exist, it should consider successful
>  # create a new method called deleteRecursively() that will only throw exception upon
error.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message