helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j...@apache.org
Subject [2/3] helix git commit: [HELIX-676] Adding test for intermediate state cal stage.
Date Tue, 13 Mar 2018 22:50:21 GMT
[HELIX-676] Adding test for intermediate state cal stage.

Testing 4 cases (recovery, load balance, recovery with transient states, and error partition
blocks load balance).
This test covers the recent fix for HELIX-676.


Project: http://git-wip-us.apache.org/repos/asf/helix/repo
Commit: http://git-wip-us.apache.org/repos/asf/helix/commit/08ff9d0b
Tree: http://git-wip-us.apache.org/repos/asf/helix/tree/08ff9d0b
Diff: http://git-wip-us.apache.org/repos/asf/helix/diff/08ff9d0b

Branch: refs/heads/master
Commit: 08ff9d0b287ece2a17f2430ba82bd4f2373263e7
Parents: 9083950
Author: Jiajun Wang <jjwang@linkedin.com>
Authored: Fri Feb 16 16:31:27 2018 -0800
Committer: jiajunwang <ericwang1985@gmail.com>
Committed: Thu Mar 8 17:25:01 2018 -0800

----------------------------------------------------------------------
 .../stages/TestIntermediateStateCalcStage.java  | 147 +++++++++++++++++++
 1 file changed, 147 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/helix/blob/08ff9d0b/helix-core/src/test/java/org/apache/helix/controller/stages/TestIntermediateStateCalcStage.java
----------------------------------------------------------------------
diff --git a/helix-core/src/test/java/org/apache/helix/controller/stages/TestIntermediateStateCalcStage.java
b/helix-core/src/test/java/org/apache/helix/controller/stages/TestIntermediateStateCalcStage.java
new file mode 100644
index 0000000..816b374
--- /dev/null
+++ b/helix-core/src/test/java/org/apache/helix/controller/stages/TestIntermediateStateCalcStage.java
@@ -0,0 +1,147 @@
+package org.apache.helix.controller.stages;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.helix.api.config.StateTransitionThrottleConfig;
+import org.apache.helix.model.ClusterConfig;
+import org.apache.helix.model.IdealState;
+import org.apache.helix.model.Partition;
+import org.testng.Assert;
+import org.testng.annotations.Test;
+
+import java.util.*;
+
+public class TestIntermediateStateCalcStage extends BaseStageTest {
+
+  @Test public void testNoStateMissing() {
+    String resourcePrefix = "resource";
+    int nResource = 4;
+    int nPartition = 2;
+    int nReplica = 3;
+
+    Set<String> resourceSet = new HashSet<>();
+    for (int i = 0; i < nResource; i++) {
+      resourceSet.add(resourcePrefix + "_" + i);
+    }
+
+    preSetup(StateTransitionThrottleConfig.RebalanceType.RECOVERY_BALANCE, resourceSet, nReplica,
+        nReplica);
+    event.addAttribute(AttributeName.RESOURCES.name(),
+        getResourceMap(resourceSet.toArray(new String[resourceSet.size()]), nPartition,
+            "OnlineOffline"));
+    event.addAttribute(AttributeName.RESOURCES_TO_REBALANCE.name(),
+        getResourceMap(resourceSet.toArray(new String[resourceSet.size()]), nPartition,
+            "OnlineOffline"));
+
+    // Initialize bestpossible state and current state
+    BestPossibleStateOutput bestPossibleStateOutput = new BestPossibleStateOutput();
+    CurrentStateOutput currentStateOutput = new CurrentStateOutput();
+
+    IntermediateStateOutput expectedResult = new IntermediateStateOutput();
+
+    for (String resource : resourceSet) {
+      IdealState is = accessor.getProperty(accessor.keyBuilder().idealStates(resource));
+      setSingleIdealState(is);
+
+      Map<String, List<String>> partitionMap = new HashMap<String, List<String>>();
+      for (int p = 0; p < nPartition; p++) {
+        Partition partition = new Partition(resource + "_" + p);
+        for (int r = 0; r < nReplica; r++) {
+          String instanceName = HOSTNAME_PREFIX + r;
+          partitionMap.put(partition.getPartitionName(), Collections.singletonList(instanceName));
+          if (resource.endsWith("0")) {
+            // Regular recovery balance
+            currentStateOutput.setCurrentState(resource, partition, instanceName, "OFFLINE");
+            bestPossibleStateOutput.setState(resource, partition, instanceName, "ONLINE");
+            // should be recovered:
+            expectedResult.setState(resource, partition, instanceName, "ONLINE");
+          } else if (resource.endsWith("1")) {
+            // Regular load balance
+            currentStateOutput.setCurrentState(resource, partition, instanceName, "ONLINE");
+            currentStateOutput.setCurrentState(resource, partition, instanceName + "-1",
"OFFLINE");
+            bestPossibleStateOutput.setState(resource, partition, instanceName, "ONLINE");
+            // should be recovered:
+            expectedResult.setState(resource, partition, instanceName, "ONLINE");
+          } else if (resource.endsWith("2")) {
+            // Recovery balance with transient states, should keep the current states in
the output.
+            currentStateOutput.setCurrentState(resource, partition, instanceName, "OFFLINE");
+            bestPossibleStateOutput.setState(resource, partition, instanceName, "OFFLINE");
+            // should be kept unchanged:
+            expectedResult.setState(resource, partition, instanceName, "OFFLINE");
+          } else if (resource.endsWith("3")) {
+            // One unresolved error should not prevent recovery balance
+            bestPossibleStateOutput.setState(resource, partition, instanceName, "ONLINE");
+            if (p == 0) {
+              if (r == 0) {
+                currentStateOutput.setCurrentState(resource, partition, instanceName, "ERROR");
+                bestPossibleStateOutput.setState(resource, partition, instanceName, "ERROR");
+                // This partition is still ERROR
+                expectedResult.setState(resource, partition, instanceName, "ERROR");
+              } else {
+                currentStateOutput.setCurrentState(resource, partition, instanceName, "OFFLINE");
+                // Recovery balance
+                expectedResult.setState(resource, partition, instanceName, "ONLINE");
+              }
+            } else {
+              currentStateOutput.setCurrentState(resource, partition, instanceName, "ONLINE");
+              currentStateOutput
+                  .setCurrentState(resource, partition, instanceName + "-1", "OFFLINE");
+              // load balance is throttled, so keep all current states
+              expectedResult.setState(resource, partition, instanceName, "ONLINE");
+              expectedResult.setState(resource, partition, instanceName + "-1", "OFFLINE");
+            }
+          }
+        }
+      }
+      bestPossibleStateOutput.setPreferenceLists(resource, partitionMap);
+    }
+
+    event.addAttribute(AttributeName.BEST_POSSIBLE_STATE.name(), bestPossibleStateOutput);
+    event.addAttribute(AttributeName.CURRENT_STATE.name(), currentStateOutput);
+    runStage(event, new ReadClusterDataStage());
+
+    // Keep update the current state.
+    for (int i = 0; i < resourceSet.size(); i++) {
+      runStage(event, new IntermediateStateCalcStage());
+    }
+
+    IntermediateStateOutput output = event.getAttribute(AttributeName.INTERMEDIATE_STATE.name());
+    for (String resource : resourceSet) {
+      // Note Assert.assertEquals won't work. If "actual" is an empty map, it won't compare
anything.
+      Assert.assertTrue(output.getPartitionStateMap(resource).getStateMap().equals(
+          expectedResult.getPartitionStateMap(resource).getStateMap()));
+    }
+  }
+
+  private void preSetup(StateTransitionThrottleConfig.RebalanceType rebalanceType,
+      Set<String> resourceSet, int numOfLiveInstances, int numOfReplicas) {
+    setupIdealState(numOfLiveInstances, resourceSet.toArray(new String[resourceSet.size()]),
+        numOfLiveInstances, numOfReplicas, IdealState.RebalanceMode.FULL_AUTO, "OnlineOffline");
+    setupStateModel();
+    setupLiveInstances(numOfLiveInstances);
+
+    // Set up cluster configs
+    ClusterConfig clusterConfig = accessor.getProperty(accessor.keyBuilder().clusterConfig());
+    StateTransitionThrottleConfig throttleConfig = new StateTransitionThrottleConfig(rebalanceType,
+        StateTransitionThrottleConfig.ThrottleScope.CLUSTER, Integer.MAX_VALUE);
+    clusterConfig.setStateTransitionThrottleConfigs(Collections.singletonList(throttleConfig));
+    setClusterConfig(clusterConfig);
+  }
+}


Mime
View raw message