helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j...@apache.org
Subject helix git commit: Revert setting job state to NOT_STARTED on creation in WorkflowRebalancer
Date Fri, 20 Apr 2018 00:44:19 GMT
Repository: helix
Updated Branches:
  refs/heads/master fa7cabf7e -> 107952ee7


Revert setting job state to NOT_STARTED on creation in WorkflowRebalancer

Temporarily remove because it could cause confusion on the client side


Project: http://git-wip-us.apache.org/repos/asf/helix/repo
Commit: http://git-wip-us.apache.org/repos/asf/helix/commit/107952ee
Tree: http://git-wip-us.apache.org/repos/asf/helix/tree/107952ee
Diff: http://git-wip-us.apache.org/repos/asf/helix/diff/107952ee

Branch: refs/heads/master
Commit: 107952ee738e081ea86598f423fa3ff039562941
Parents: fa7cabf
Author: Hunter Lee <narendly@gmail.com>
Authored: Thu Apr 19 17:40:20 2018 -0700
Committer: Hunter Lee <narendly@gmail.com>
Committed: Thu Apr 19 17:43:48 2018 -0700

----------------------------------------------------------------------
 .../src/main/java/org/apache/helix/task/WorkflowRebalancer.java | 5 -----
 1 file changed, 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/helix/blob/107952ee/helix-core/src/main/java/org/apache/helix/task/WorkflowRebalancer.java
----------------------------------------------------------------------
diff --git a/helix-core/src/main/java/org/apache/helix/task/WorkflowRebalancer.java b/helix-core/src/main/java/org/apache/helix/task/WorkflowRebalancer.java
index 540ea13..709ba65 100644
--- a/helix-core/src/main/java/org/apache/helix/task/WorkflowRebalancer.java
+++ b/helix-core/src/main/java/org/apache/helix/task/WorkflowRebalancer.java
@@ -74,11 +74,6 @@ public class WorkflowRebalancer extends TaskRebalancer {
       workflowCtx = new WorkflowContext(new ZNRecord(TaskUtil.WORKFLOW_CONTEXT_KW));
       workflowCtx.setStartTime(System.currentTimeMillis());
       workflowCtx.setName(workflow);
-      // Initialize all job states belonging to this workflow context to NOT_STARTED
-      for (String jobState : workflowCtx.getJobStates().keySet()) {
-        workflowCtx.setJobState(jobState, TaskState.NOT_STARTED);
-      }
-      LOG.debug("Workflow context is created for " + workflow);
     }
 
     Set<TaskState> finalStates = new HashSet<>(Arrays.asList(


Mime
View raw message