helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HELIX-689) Controller message cleanup is spitting too many logs
Date Tue, 03 Apr 2018 21:30:00 GMT

    [ https://issues.apache.org/jira/browse/HELIX-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424634#comment-16424634
] 

ASF GitHub Bot commented on HELIX-689:
--------------------------------------

GitHub user zhan849 opened a pull request:

    https://github.com/apache/helix/pull/173

    [HELIX-689] remove redundant logs from zkclient

    Currently, in controller message cleanup, we print out 2 lines of message when message
does not exist, which is totally redundant. In this PR, I removed the warning message from
controller, and added error message in zkclient only when there is real error (exception from
below). If we fail to delete a ZNode because znode does not exist, we do not print out message
any more except debug mode

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhan849/helix harry/ctl-msg-cleanup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/helix/pull/173.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #173
    
----
commit d96a40caf19efffed3939b6dd8d9efe40734ec15
Author: Harry Zhang <zhan849@...>
Date:   2018-04-03T21:22:53Z

    [HELIX-689] remove redundant logs from zkclient

----


> Controller message cleanup is spitting too many logs
> ----------------------------------------------------
>
>                 Key: HELIX-689
>                 URL: https://issues.apache.org/jira/browse/HELIX-689
>             Project: Apache Helix
>          Issue Type: Bug
>            Reporter: Hao Zhang
>            Priority: Major
>
> Currently we print out error log when we fail to remove logs. However, due to ZK client
limitation, we are printing logs even when the message is already deleted, which should not
be regarded as a failure
> Need to perform log cleanup and only print out log when there is real error.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message