helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HELIX-691) Allow users to update InstanceConfig
Date Mon, 09 Apr 2018 17:56:00 GMT

    [ https://issues.apache.org/jira/browse/HELIX-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430970#comment-16430970
] 

ASF GitHub Bot commented on HELIX-691:
--------------------------------------

Github user zhan849 commented on a diff in the pull request:

    https://github.com/apache/helix/pull/174#discussion_r180178181
  
    --- Diff: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/InstanceAccessor.java
---
    @@ -315,26 +316,27 @@ public Response getInstanceConfig(@PathParam("clusterId") String
clusterId,
         return notFound();
       }
     
    -  @PUT
    +  @POST
    --- End diff --
    
    PUT is for "set" and POST is for "patch", I'd suggest we keep both. @dasahcc thoughts?


> Allow users to update InstanceConfig
> ------------------------------------
>
>                 Key: HELIX-691
>                 URL: https://issues.apache.org/jira/browse/HELIX-691
>             Project: Apache Helix
>          Issue Type: Improvement
>            Reporter: Hunter L
>            Priority: Major
>
> In helix-rest, we provide in InstanceAccessor a method updateInstanceConfig updates the
instance's config through a POST call.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message