helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HELIX-699) Compare InstanceConfigs using their IDs in RoutingTable
Date Thu, 19 Apr 2018 20:48:00 GMT

    [ https://issues.apache.org/jira/browse/HELIX-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16444766#comment-16444766
] 

ASF GitHub Bot commented on HELIX-699:
--------------------------------------

GitHub user narendly opened a pull request:

    https://github.com/apache/helix/pull/188

    [HELIX-699] Compare InstanceConfigs using their IDs in RoutingTable

    A possible race condition was causing a NPE on InstanceConfig.getHostName(). Instead of
comparing hostnames and ports, we compare IDs, which are supposed to be concatenation of instance
name, hostname, and port anyways and should always be set.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/narendly/helix instConfigNullCheck

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/helix/pull/188.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #188
    
----
commit 2b076c1f97dca95ef4ad817fd45d47c1ec4ff337
Author: Hunter Lee <narendly@...>
Date:   2018-04-19T20:47:28Z

    [HELIX-699] Compare InstanceConfigs using their IDs in RoutingTable
    
    A possible race condition was causing a NPE on InstanceConfig.getHostName(). Instead of
comparing hostnames and ports, we compare IDs, which are supposed to be concatenation of instance
name, hostname, and port anyways and should always be set.

----


> Compare InstanceConfigs using their IDs in RoutingTable
> -------------------------------------------------------
>
>                 Key: HELIX-699
>                 URL: https://issues.apache.org/jira/browse/HELIX-699
>             Project: Apache Helix
>          Issue Type: Improvement
>            Reporter: Hunter L
>            Priority: Major
>
> A possible race condition was causing a NPE on InstanceConfig.getHostName(). Instead
of comparing hostnames and ports, we compare IDs, which are supposed to be concatenation of
instance name, hostname, and port anyways and should always be set.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message