helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hu...@apache.org
Subject [helix] 24/44: Fix the public API non-backward compatible change
Date Sat, 25 May 2019 01:19:58 GMT
This is an automated email from the ASF dual-hosted git repository.

hulee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/helix.git

commit 05cf0e4a922445b46848dab152d1f8777f351ce3
Author: Yi Wang <ywang4@linkedin.com>
AuthorDate: Tue Apr 23 11:57:36 2019 -0700

    Fix the public API non-backward compatible change
    
    RB=1641513
    G=helix-reviewers
    A=hulee
    
    Signed-off-by: Hunter Lee <hulee@linkedin.com>
---
 .../src/main/java/org/apache/helix/model/InstanceConfig.java   | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/helix-core/src/main/java/org/apache/helix/model/InstanceConfig.java b/helix-core/src/main/java/org/apache/helix/model/InstanceConfig.java
index 74ba9d7..f65a1bd 100644
--- a/helix-core/src/main/java/org/apache/helix/model/InstanceConfig.java
+++ b/helix-core/src/main/java/org/apache/helix/model/InstanceConfig.java
@@ -127,6 +127,16 @@ public class InstanceConfig extends HelixProperty {
 
   /**
    * Domain represents a hierarchy identifier for an instance.
+   * This is to ensure backward compatibility, going forward please use {@link InstanceConfig#getDomainAsString()}
+   * @return
+   */
+  @Deprecated
+  public String getDomain() {
+    return _record.getSimpleField(InstanceConfigProperty.DOMAIN.name());
+  }
+
+  /**
+   * Domain represents a hierarchy identifier for an instance.
    * @return
    */
   public String getDomainAsString() {


Mime
View raw message