helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hu...@apache.org
Subject [helix] 35/44: Refine missing top state log method.
Date Sat, 25 May 2019 01:20:09 GMT
This is an automated email from the ASF dual-hosted git repository.

hulee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/helix.git

commit 54c225b04ab0dd96bc515ea5d8deb016a45c3db7
Author: Jiajun Wang <jjwang@linkedin.com>
AuthorDate: Thu May 16 15:46:29 2019 -0700

    Refine missing top state log method.
    
    The parameter naming was confusing. The log message was not clear. This RB fixes both
issues.
    
    RB=1669555
    
    RB=1669555
    G=helix-reviewers
    A=jxue
    
    Signed-off-by: Hunter Lee <hulee@linkedin.com>
---
 .../helix/controller/stages/TopStateHandoffReportStage.java   | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/helix-core/src/main/java/org/apache/helix/controller/stages/TopStateHandoffReportStage.java
b/helix-core/src/main/java/org/apache/helix/controller/stages/TopStateHandoffReportStage.java
index c03d23a..6fbd36e 100644
--- a/helix-core/src/main/java/org/apache/helix/controller/stages/TopStateHandoffReportStage.java
+++ b/helix-core/src/main/java/org/apache/helix/controller/stages/TopStateHandoffReportStage.java
@@ -21,8 +21,9 @@ package org.apache.helix.controller.stages;
 
 import java.util.HashMap;
 import java.util.Map;
-import org.apache.helix.controller.dataproviders.BaseControllerDataProvider;
+
 import org.apache.helix.controller.LogUtil;
+import org.apache.helix.controller.dataproviders.BaseControllerDataProvider;
 import org.apache.helix.controller.dataproviders.ResourceControllerDataProvider;
 import org.apache.helix.controller.dataproviders.WorkflowControllerDataProvider;
 import org.apache.helix.controller.pipeline.AbstractBaseStage;
@@ -500,10 +501,10 @@ public class TopStateHandoffReportStage extends AbstractBaseStage {
     }
   }
 
-  private void logMissingTopStateInfo(long totalDuration, long userLatency, boolean isGraceful,
+  private void logMissingTopStateInfo(long totalDuration, long helixLatency, boolean isGraceful,
       String partitionName) {
-    LogUtil.logInfo(LOG, _eventId, String
-        .format("Missing top state duration is %s/%s for partition %s. Graceful: %s", userLatency,
-            totalDuration, partitionName, isGraceful));
+    LogUtil.logInfo(LOG, _eventId, String.format(
+        "Missing top state duration is %s/%s (helix latency / end to end latency) for partition
%s. Graceful: %s",
+        helixLatency, totalDuration, partitionName, isGraceful));
   }
 }


Mime
View raw message