helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hu...@apache.org
Subject [helix] branch master updated: Remove the closing of ZkClient in afterClass() in TestZkBaseDataAccessor (#604)
Date Thu, 14 Nov 2019 07:33:15 GMT
This is an automated email from the ASF dual-hosted git repository.

hulee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/helix.git


The following commit(s) were added to refs/heads/master by this push:
     new 0405399  Remove the closing of ZkClient in afterClass() in TestZkBaseDataAccessor
(#604)
0405399 is described below

commit 04053998bab60553113ea5eba8acd2bc6b294a86
Author: Yi Wang <i3.wangyi@gmail.com>
AuthorDate: Wed Nov 13 23:33:07 2019 -0800

    Remove the closing of ZkClient in afterClass() in TestZkBaseDataAccessor (#604)
    
    The introduced close() of gzkClient in the afterclass method in zkBaseDataAccessor will
lead to the mvn test failing cause the gzkClient is in zkTestBase. This PR removes the close()
method.
---
 .../java/org/apache/helix/manager/zk/TestZkBaseDataAccessor.java    | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/helix-core/src/test/java/org/apache/helix/manager/zk/TestZkBaseDataAccessor.java
b/helix-core/src/test/java/org/apache/helix/manager/zk/TestZkBaseDataAccessor.java
index a623680..fb78d1c 100644
--- a/helix-core/src/test/java/org/apache/helix/manager/zk/TestZkBaseDataAccessor.java
+++ b/helix-core/src/test/java/org/apache/helix/manager/zk/TestZkBaseDataAccessor.java
@@ -40,7 +40,6 @@ import org.apache.helix.manager.zk.ZkBaseDataAccessor.AccessResult;
 import org.apache.helix.manager.zk.ZkBaseDataAccessor.RetCode;
 import org.apache.zookeeper.data.Stat;
 import org.testng.Assert;
-import org.testng.annotations.AfterClass;
 import org.testng.annotations.AfterMethod;
 import org.testng.annotations.Test;
 
@@ -74,11 +73,6 @@ public class TestZkBaseDataAccessor extends ZkUnitTestBase {
     }
   }
 
-  @AfterClass
-  public void afterClass() {
-    _gZkClient.close();
-  }
-
   @Test
   public void testSyncSet() {
     String className = TestHelper.getTestClassName();


Mime
View raw message