helix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hu...@apache.org
Subject [helix] branch master updated: Stabilize the TestAlertingRebalancerFailure test (#608)
Date Tue, 19 Nov 2019 12:38:13 GMT
This is an automated email from the ASF dual-hosted git repository.

hulee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/helix.git


The following commit(s) were added to refs/heads/master by this push:
     new bc46dad  Stabilize the TestAlertingRebalancerFailure test (#608)
bc46dad is described below

commit bc46dad1922c143407085a5c21ebed3707be7c7e
Author: Ali Reza Zamani Zadeh Najari <anajari@linkedin.com>
AuthorDate: Tue Nov 19 04:38:04 2019 -0800

    Stabilize the TestAlertingRebalancerFailure test (#608)
    
    TestAlertingRebalancerFailure was made stable.
    
    This test was unstable because there were some race condition between two tests (cleanup
of testParticipantUnavailable and start of the testTagSetIncorrect). Due to this race condition,
the listfield and mapfield in the IdealState have been missing for the testTagSetIncorrect
test. Hence, rebalancer does not run as expected.
---
 .../java/org/apache/helix/integration/TestAlertingRebalancerFailure.java | 1 +
 1 file changed, 1 insertion(+)

diff --git a/helix-core/src/test/java/org/apache/helix/integration/TestAlertingRebalancerFailure.java
b/helix-core/src/test/java/org/apache/helix/integration/TestAlertingRebalancerFailure.java
index b19f4c2..404c8da 100644
--- a/helix-core/src/test/java/org/apache/helix/integration/TestAlertingRebalancerFailure.java
+++ b/helix-core/src/test/java/org/apache/helix/integration/TestAlertingRebalancerFailure.java
@@ -164,6 +164,7 @@ public class TestAlertingRebalancerFailure extends ZkStandAloneCMTestBase
{
         BuiltInStateModelDefinitions.MasterSlave.name(), RebalanceMode.FULL_AUTO.name());
     ZkHelixClusterVerifier verifier = new BestPossibleExternalViewVerifier.Builder(CLUSTER_NAME)
         .setZkAddr(ZK_ADDR).setResources(new HashSet<>(Collections.singleton(testDb))).build();
+    _gSetupTool.getClusterManagementTool().rebalance(CLUSTER_NAME, testDb, 3);
     Assert.assertTrue(verifier.verifyByPolling());
 
     // Verify there is no rebalance error logged


Mime
View raw message