hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Chauhan (JIRA)" <>
Subject [jira] [Commented] (HIVE-18053) Support different table types for MVs
Date Fri, 22 Dec 2017 00:30:03 GMT


Ashutosh Chauhan commented on HIVE-18053:

Code changes look good. Few comments w.r.t comments:
 final List<String> qualifiedTableName;
   if (tableRel instanceof Project) {
   	      qualifiedTableName = tableRel.getInput(0).getTable().getQualifiedName();
   	      	    } else {
	   qualifiedTableName = tableRel.getTable().getQualifiedName();
Good to add a comment on when tableRel can be a Project. Also, that it can't be of 3rd type.

DruidQuery.create(cluster, cluster.traitSetOf(BindableConvention.INSTANCE),
Good to a comment of effect that ideally we shall use HiveRelNode convention. But since Volcano
planner throws in that case, we set it as Bindable. Since,
we do't really use convention currently its ok. In future if we want to make use of convention
(e.g., while directly generation op tree instead of AST) this needs to be changed.

String viewText = tab.getViewExpandedText();
Good to add a comment on why this needs expanded text.

Also patch introduces checkstyle warnings. 

> Support different table types for MVs
> -------------------------------------
>                 Key: HIVE-18053
>                 URL:
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Materialized views
>    Affects Versions: 3.0.0
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Jesus Camacho Rodriguez
>            Priority: Critical
>         Attachments: HIVE-18053.patch
> MVs backed by MM tables, managed tables, external tables. This might work already, but
we need to add tests.

This message was sent by Atlassian JIRA

View raw message