hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sahil Takiar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-18883) Add findbugs to yetus pre-commit checks
Date Fri, 13 Apr 2018 19:28:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-18883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437784#comment-16437784
] 

Sahil Takiar commented on HIVE-18883:
-------------------------------------

Ok think I found the issue. This patch isn't working on ptest because the {{patchprocess}}
directory gets deleted as soon as Yetus starts to run because it requires a clean workspace
(we could specify the {{--dirty-workspace}} option, but that seems dangerous). Yetus checks
for the Findbugs directories after it cleans the workspace, so it decides not to run Findbugs.

Looking at other Apache components, they install Findbugs in a docker image and then set {{FINDBUGS_HOME}}.
Unfortunately, we don't follow that model, so I need to brainstorm an alternative place to
install the Findbugs distribution. It doesn't look like we can install it anywhere in the
cloned git repo.

> Add findbugs to yetus pre-commit checks
> ---------------------------------------
>
>                 Key: HIVE-18883
>                 URL: https://issues.apache.org/jira/browse/HIVE-18883
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Testing Infrastructure
>            Reporter: Sahil Takiar
>            Assignee: Sahil Takiar
>            Priority: Major
>             Fix For: 3.1.0
>
>         Attachments: HIVE-18883.1.patch, HIVE-18883.2.patch
>
>
> We should enable FindBugs for our YETUS pre-commit checks, this will help overall code
quality and should decrease the overall number of bugs in Hive.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message