hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zoltan Haindrich (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-19131) DecimalColumnStatsMergerTest comparison review
Date Fri, 13 Apr 2018 14:00:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Zoltan Haindrich updated HIVE-19131:
------------------------------------
    Target Version/s: 3.0.0

> DecimalColumnStatsMergerTest comparison review
> ----------------------------------------------
>
>                 Key: HIVE-19131
>                 URL: https://issues.apache.org/jira/browse/HIVE-19131
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Laszlo Bodor
>            Assignee: Laszlo Bodor
>            Priority: Major
>
> DecimalColumnStatsMergerTest has a strange comparison logic, which needs to be reviewed.
> Regarding low and high values, it uses compareTo with the same direction, which seems
to be incorrect: old.compareTo(new) > 0 -> pick old value in both cases
> {code:java}
> Decimal lowValue = aggregateData.getLowValue() != null && (aggregateData.getLowValue().compareTo(newData.getLowValue())
> 0) ? aggregateData .getLowValue() : newData.getLowValue(); aggregateData.setLowValue(lowValue);

> Decimal highValue = aggregateData.getHighValue() != null && (aggregateData.getHighValue().compareTo(newData.getHighValue())
> 0) ? aggregateData .getHighValue() : newData.getHighValue();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message