hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (HIVE-20953) Remove a function from function registry when it can not be added to the metastore when creating it.
Date Tue, 04 Dec 2018 04:32:00 GMT


ASF GitHub Bot commented on HIVE-20953:

Github user ashutosh-bapat closed the pull request at:

> Remove a function from function registry when it can not be added to the metastore when
creating it.
> ----------------------------------------------------------------------------------------------------
>                 Key: HIVE-20953
>                 URL:
>             Project: Hive
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 4.0.0
>            Reporter: Ashutosh Bapat
>            Assignee: Ashutosh Bapat
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.0.0
>         Attachments: HIVE-20953.01, HIVE-20953.02, HIVE-20953.02, HIVE-20953.03, HIVE-20953.03,
>   Original Estimate: 24h
>  Remaining Estimate: 24h
> The testcase is intended to test REPL LOAD with retry. The test creates a partitioned
table and a function in the source database and loads those to the replica. The first attempt
to load a dump is intended to fail while loading one of the partitions. Based on the order
in which the objects get loaded, if the function is queued after the table, it will not be
available in replica after the load failure. But if it's queued before the table, it will
be available in replica even after the load failure. The test assumes the later case, which
may not be true always.
> Hence fix the testcase to order the objects by a fixed ordering. By setting
to true, the objects are ordered by the directory names. This ordering is available with
minimal changes for testing, hence we use it. With this ordering a function gets loaded before
a table. So changed the test to not expect the function to be available after the failed
load, but be available after the retry.
> While writing that testcase, I found that even if a function fails to load, it's visible
through show functions and also is available to be called just as if the failure has not happened.
Digging further it was found that when creating a function we add it to the registry and also
to the metastore. If the later fails, we do not clean it up from the registry and thus it
remains visible after failure. Fixed the same.

This message was sent by Atlassian JIRA

View raw message