hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-21576) Introduce CAST...FORMAT and limited list of SQL:2016 datetime formats
Date Thu, 13 Jun 2019 03:23:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-21576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16862687#comment-16862687
] 

Hive QA commented on HIVE-21576:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 46s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 27s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 43s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 17s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 35s{color} | {color:blue}
common in master has 62 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 39s{color} | {color:blue}
serde in master has 193 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m 13s{color} | {color:blue}
ql in master has 2260 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 32s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 30s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m  9s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 45s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 45s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 13s{color} | {color:red}
common: The patch generated 4 new + 3 unchanged - 2 fixed = 7 total (was 5) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 17s{color} | {color:red}
serde: The patch generated 4 new + 200 unchanged - 24 fixed = 204 total (was 224) {color}
|
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 44s{color}
| {color:green} ql: The patch generated 0 new + 494 unchanged - 2 fixed = 494 total (was 496)
{color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  0s{color} | {color:red}
The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.
Refer https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  4m 29s{color} | {color:red}
ql generated 41 new + 2235 unchanged - 25 fixed = 2276 total (was 2260) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 32s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 15s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 33m 47s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  Class org.apache.hadoop.hive.ql.exec.vector.expressions.CastDateToCharWithFormat defines
non-transient non-serializable instance field formatter  In CastDateToCharWithFormat.java:instance
field formatter  In CastDateToCharWithFormat.java |
|  |  org.apache.hadoop.hive.common.format.datetime.HiveSqlDateTimeFormatter stored into non-transient
field CastDateToCharWithFormat.formatter  At CastDateToCharWithFormat.java:CastDateToCharWithFormat.formatter
 At CastDateToCharWithFormat.java:[line 46] |
|  |  Found reliance on default encoding in org.apache.hadoop.hive.ql.exec.vector.expressions.CastDateToString.func(BytesColumnVector,
long[], int, HiveDateTimeFormatter):in org.apache.hadoop.hive.ql.exec.vector.expressions.CastDateToString.func(BytesColumnVector,
long[], int, HiveDateTimeFormatter): String.getBytes()  At CastDateToString.java:[line 65]
|
|  |  Class org.apache.hadoop.hive.ql.exec.vector.expressions.CastDateToStringWithFormat defines
non-transient non-serializable instance field formatter  In CastDateToStringWithFormat.java:instance
field formatter  In CastDateToStringWithFormat.java |
|  |  org.apache.hadoop.hive.common.format.datetime.HiveSqlDateTimeFormatter stored into non-transient
field CastDateToStringWithFormat.formatter  At CastDateToStringWithFormat.java:CastDateToStringWithFormat.formatter
 At CastDateToStringWithFormat.java:[line 47] |
|  |  Class org.apache.hadoop.hive.ql.exec.vector.expressions.CastDateToVarCharWithFormat
defines non-transient non-serializable instance field formatter  In CastDateToVarCharWithFormat.java:instance
field formatter  In CastDateToVarCharWithFormat.java |
|  |  org.apache.hadoop.hive.common.format.datetime.HiveSqlDateTimeFormatter stored into non-transient
field CastDateToVarCharWithFormat.formatter  At CastDateToVarCharWithFormat.java:CastDateToVarCharWithFormat.formatter
 At CastDateToVarCharWithFormat.java:[line 46] |
|  |  Class org.apache.hadoop.hive.ql.exec.vector.expressions.CastStringToDateWithFormat defines
non-transient non-serializable instance field formatter  In CastStringToDateWithFormat.java:instance
field formatter  In CastStringToDateWithFormat.java |
|  |  org.apache.hadoop.hive.common.format.datetime.HiveSqlDateTimeFormatter stored into non-transient
field CastStringToDateWithFormat.formatter  At CastStringToDateWithFormat.java:CastStringToDateWithFormat.formatter
 At CastStringToDateWithFormat.java:[line 48] |
|  |  Class org.apache.hadoop.hive.ql.exec.vector.expressions.CastStringToTimestampWithFormat
defines non-transient non-serializable instance field formatter  In CastStringToTimestampWithFormat.java:instance
field formatter  In CastStringToTimestampWithFormat.java |
|  |  org.apache.hadoop.hive.common.format.datetime.HiveSqlDateTimeFormatter stored into non-transient
field CastStringToTimestampWithFormat.formatter  At CastStringToTimestampWithFormat.java:CastStringToTimestampWithFormat.formatter
 At CastStringToTimestampWithFormat.java:[line 48] |
|  |  Class org.apache.hadoop.hive.ql.exec.vector.expressions.CastTimestampToCharWithFormat
defines non-transient non-serializable instance field formatter  In CastTimestampToCharWithFormat.java:instance
field formatter  In CastTimestampToCharWithFormat.java |
|  |  org.apache.hadoop.hive.common.format.datetime.HiveSqlDateTimeFormatter stored into non-transient
field CastTimestampToCharWithFormat.formatter  At CastTimestampToCharWithFormat.java:CastTimestampToCharWithFormat.formatter
 At CastTimestampToCharWithFormat.java:[line 47] |
|  |  Found reliance on default encoding in org.apache.hadoop.hive.ql.exec.vector.expressions.CastTimestampToString.func(BytesColumnVector,
TimestampColumnVector, int, HiveDateTimeFormatter):in org.apache.hadoop.hive.ql.exec.vector.expressions.CastTimestampToString.func(BytesColumnVector,
TimestampColumnVector, int, HiveDateTimeFormatter): String.getBytes()  At CastTimestampToString.java:[line
83] |
|  |  Class org.apache.hadoop.hive.ql.exec.vector.expressions.CastTimestampToStringWithFormat
defines non-transient non-serializable instance field formatter  In CastTimestampToStringWithFormat.java:instance
field formatter  In CastTimestampToStringWithFormat.java |
|  |  org.apache.hadoop.hive.common.format.datetime.HiveSqlDateTimeFormatter stored into non-transient
field CastTimestampToStringWithFormat.formatter  At CastTimestampToStringWithFormat.java:CastTimestampToStringWithFormat.formatter
 At CastTimestampToStringWithFormat.java:[line 46] |
|  |  Class org.apache.hadoop.hive.ql.exec.vector.expressions.CastTimestampToVarCharWithFormat
defines non-transient non-serializable instance field formatter  In CastTimestampToVarCharWithFormat.java:instance
field formatter  In CastTimestampToVarCharWithFormat.java |
|  |  org.apache.hadoop.hive.common.format.datetime.HiveSqlDateTimeFormatter stored into non-transient
field CastTimestampToVarCharWithFormat.formatter  At CastTimestampToVarCharWithFormat.java:CastTimestampToVarCharWithFormat.formatter
 At CastTimestampToVarCharWithFormat.java:[line 47] |
|  |  Switch statement found in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.castExpression()
where default case is missing  At HiveParser_IdentifiersParser.java:where default case is
missing  At HiveParser_IdentifiersParser.java:[lines 3966-3974] |
|  |  Dead store to LA31_100 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 33394] |
|  |  Dead store to LA31_101 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 33407] |
|  |  Dead store to LA31_102 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 33420] |
|  |  Dead store to LA31_15 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 33290] |
|  |  Dead store to LA31_16 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 33303] |
|  |  Dead store to LA31_17 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 33316] |
|  |  Dead store to LA31_18 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 33329] |
|  |  Dead store to LA31_19 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 33342] |
|  |  Dead store to LA31_97 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 33355] |
|  |  Dead store to LA31_98 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 33368] |
|  |  Dead store to LA31_99 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 33381] |
|  |  Should org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32 be a _static_
inner class?  At HiveParser_IdentifiersParser.java:inner class?  At HiveParser_IdentifiersParser.java:[lines
33566-33579] |
|  |  Dead store to LA36_169 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA36.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA36.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 33866] |
|  |  Should org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA38 be a _static_
inner class?  At HiveParser_IdentifiersParser.java:inner class?  At HiveParser_IdentifiersParser.java:[lines
35076-35089] |
|  |  Should org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA47 be a _static_
inner class?  At HiveParser_IdentifiersParser.java:inner class?  At HiveParser_IdentifiersParser.java:[lines
35997-36010] |
|  |  Should org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA51 be a _static_
inner class?  At HiveParser_IdentifiersParser.java:inner class?  At HiveParser_IdentifiersParser.java:[lines
36486-36499] |
|  |  Dead store to LA54_48 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 36744] |
|  |  Dead store to LA54_56 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 36757] |
|  |  Dead store to LA54_57 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 36770] |
|  |  Dead store to LA54_58 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 36783] |
|  |  Dead store to LA54_59 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 36796] |
|  |  org.apache.hadoop.hive.ql.udf.generic.GenericUDFCastFormat is Serializable; consider
declaring a serialVersionUID  At GenericUDFCastFormat.java:a serialVersionUID  At GenericUDFCastFormat.java:[lines
56-207] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-17546/dev-support/hive-personality.sh
|
| git revision | master / acaa98c |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-17546/yetus/diff-checkstyle-common.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-17546/yetus/diff-checkstyle-serde.txt
|
| whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-17546/yetus/whitespace-eol.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-17546/yetus/new-findbugs-ql.html
|
| modules | C: common serde ql U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-17546/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Introduce CAST...FORMAT and limited list of SQL:2016 datetime formats
> ---------------------------------------------------------------------
>
>                 Key: HIVE-21576
>                 URL: https://issues.apache.org/jira/browse/HIVE-21576
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Karen Coppage
>            Assignee: Karen Coppage
>            Priority: Major
>         Attachments: HIVE-21576.01.patch, HIVE-21576.03.patch, HIVE-21576.04.patch, HIVE-21576.05.patch,
HIVE-21576.06.patch, HIVE-21576.07.patch, HIVE-21576.08.patch, HIVE-21576.09.patch, HIVE-21576.10.patch,
HIVE-21576.11.patch, HIVE-21576.2.patch
>
>
> Introduce FORMAT clause to CAST statements as well as the below limited list of SQL:2016
datetime formats to Hive in general.
>  * YYYY
>  * MM
>  * DD
>  * HH
>  * MI
>  * SS
>  * YYY
>  * YY
>  * Y
>  * RRRR
>  * RR
>  * DDD
>  * HH12
>  * HH24
>  * SSSSS
>  * FF[1..9]
>  * AM/A.M.
>  * PM/P.M.
>  * TZH
>  * TZM
> Definitions of these formats here: [https://docs.google.com/document/d/1V7k6-lrPGW7_uhqM-FhKl3QsxwCRy69v2KIxPsGjc1k/|https://docs.google.com/document/d/1V7k6-lrPGW7_uhqM-FhKl3QsxwCRy69v2KIxPsGjc1k/edit]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message