hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-21742) Vectorization: CASE result type casting
Date Tue, 04 Jun 2019 22:10:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-21742?focusedWorklogId=254054&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-254054
]

ASF GitHub Bot logged work on HIVE-21742:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Jun/19 22:09
            Start Date: 04/Jun/19 22:09
    Worklog Time Spent: 10m 
      Work Description: vineetgarg02 commented on pull request #656: HIVE-21742 : Vectorization:
CASE result type casting
URL: https://github.com/apache/hive/pull/656#discussion_r290516708
 
 

 ##########
 File path: ql/src/test/results/clientpositive/llap/multi_count_distinct_null.q.out
 ##########
 @@ -73,7 +73,7 @@ STAGE PLANS:
                 outputColumnNames: _col0, _col1, _col2, _col3
                 Statistics: Num rows: 18 Data size: 1628 Basic stats: COMPLETE Column stats:
COMPLETE
                 Select Operator
-                  expressions: CASE WHEN (((_col3 = 3L) and _col0 is not null)) THEN (1)
ELSE (null) END (type: int), CASE WHEN (((_col3 = 5L) and _col1 is not null)) THEN (1) ELSE
(null) END (type: int), CASE WHEN (((_col3 = 6L) and _col2 is not null)) THEN (1) ELSE (null)
END (type: int)
+                  expressions: CASE WHEN (((_col3 = 3L) and _col0 is not null)) THEN (1)
ELSE (UDFToInteger(null)) END (type: int), CASE WHEN (((_col3 = 5L) and _col1 is not null))
THEN (1) ELSE (UDFToInteger(null)) END (type: int), CASE WHEN (((_col3 = 6L) and _col2 is
not null)) THEN (1) ELSE (UDFToInteger(null)) END (type: int)
 
 Review comment:
   Latest update fixes constant folding issue.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 254054)
    Time Spent: 3h 20m  (was: 3h 10m)

> Vectorization: CASE result type casting
> ---------------------------------------
>
>                 Key: HIVE-21742
>                 URL: https://issues.apache.org/jira/browse/HIVE-21742
>             Project: Hive
>          Issue Type: Bug
>          Components: Logical Optimizer, Vectorization
>    Affects Versions: 3.1.1
>            Reporter: Gopal V
>            Assignee: Vineet Garg
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-21742.1.patch, HIVE-21742.2.patch, HIVE-21742.3.patch, HIVE-21742.4.patch,
HIVE-21799.4.patch
>
>          Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> {code}
> create temporary table foo(q548284 int);
> insert into foo values(1),(2),(3),(4),(5),(6);
> select q548284, CASE WHEN ((q548284 = 1)) THEN (0.2) WHEN ((q548284 = 2)) THEN (0.4)
WHEN ((q548284 = 3)) THEN (0.6) WHEN ((q548284 = 4)) THEN (0.8) WHEN ((q548284 = 5)) THEN
(1) ELSE (null) END from foo order by q548284 limit 1;
> {code}
> Fails with 
> {code}
> Caused by: java.lang.ClassCastException: org.apache.hadoop.hive.ql.exec.vector.LongColumnVector
cannot be cast to org.apache.hadoop.hive.ql.exec.vector.DecimalColumnVector
>         at org.apache.hadoop.hive.ql.exec.vector.DecimalColumnVector.setElement(DecimalColumnVector.java:130)
>         at org.apache.hadoop.hive.ql.exec.vector.expressions.IfExprColumnNull.evaluate(IfExprColumnNull.java:101)
> {code}
> This gets fixed if the case return of (1) is turned into a (1.0).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message