hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-21818) CBO: Copying TableRelOptHiveTable has metastore traffic
Date Thu, 06 Jun 2019 21:05:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-21818?focusedWorklogId=255439&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-255439
]

ASF GitHub Bot logged work on HIVE-21818:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Jun/19 21:04
            Start Date: 06/Jun/19 21:04
    Worklog Time Spent: 10m 
      Work Description: jcamachor commented on pull request #663: HIVE-21818
URL: https://github.com/apache/hive/pull/663#discussion_r291368644
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java
 ##########
 @@ -275,103 +279,107 @@ public boolean isKey(ImmutableBitSet columns) {
       nonNullbuilder.add(key);
     }
     // Then UKs
-    final UniqueConstraint uki;
-    try {
-      uki = Hive.get().getReliableUniqueConstraints(
-          hiveTblMetadata.getDbName(), hiveTblMetadata.getTableName());
-    } catch (HiveException e) {
-      throw new RuntimeException(e);
-    }
-    for (List<UniqueConstraintCol> ukCols : uki.getUniqueConstraints().values()) {
-      ImmutableBitSet.Builder keys = ImmutableBitSet.builder();
-      boolean isNonNullable = true;
-      for (UniqueConstraintCol ukCol : ukCols) {
-        int ukPos;
-        for (ukPos = 0; ukPos < rowType.getFieldNames().size(); ukPos++) {
-          String colName = rowType.getFieldNames().get(ukPos);
-          if (ukCol.colName.equals(colName)) {
-            if(rowType.getFieldList().get(ukPos).getType().isNullable()) {
-              // they should all be nullable
-              isNonNullable = false;
+    if (uniqueKeyInfo != null && !uniqueKeyInfo.getUniqueConstraints().isEmpty())
{
+      for (List<UniqueConstraintCol> ukCols : uniqueKeyInfo.getUniqueConstraints().values())
{
+        ImmutableBitSet.Builder keys = ImmutableBitSet.builder();
+        boolean isNonNullable = true;
+        for (UniqueConstraintCol ukCol : ukCols) {
+          int ukPos;
+          for (ukPos = 0; ukPos < rowType.getFieldNames().size(); ukPos++) {
+            String colName = rowType.getFieldNames().get(ukPos);
+            if (ukCol.colName.equals(colName)) {
+              if (rowType.getFieldList().get(ukPos).getType().isNullable()) {
+                // they should all be nullable
+                isNonNullable = false;
+              }
+              break;
             }
-            break;
           }
+          if (ukPos == rowType.getFieldNames().size()) {
+            LOG.error("Column for unique constraint definition " + ukCol.colName + " not
found");
+          }
+          keys.set(ukPos);
         }
-        if (ukPos == rowType.getFieldNames().size()) {
-          LOG.error("Column for unique constraint definition " + ukCol.colName + " not found");
+        ImmutableBitSet key = keys.build();
+        builder.add(key);
+        if (isNonNullable) {
+          nonNullbuilder.add(key);
         }
-        keys.set(ukPos);
-      }
-      ImmutableBitSet key = keys.build();
-      builder.add(key);
-      if(isNonNullable) {
-        nonNullbuilder.add(key);
       }
     }
     return new Pair<>(builder.build(), nonNullbuilder.build());
   }
 
   private List<RelReferentialConstraint> generateReferentialConstraints() {
-    final ForeignKeyInfo fki;
-    try {
-      fki = Hive.get().getReliableForeignKeys(
-          hiveTblMetadata.getDbName(), hiveTblMetadata.getTableName());
-    } catch (HiveException e) {
-      throw new RuntimeException(e);
-    }
+    final ForeignKeyInfo foreignKeyInfo = hiveTblMetadata.getForeignKeyInfo();
     ImmutableList.Builder<RelReferentialConstraint> builder = ImmutableList.builder();
-    for (List<ForeignKeyCol> fkCols : fki.getForeignKeys().values()) {
-      List<String> foreignKeyTableQualifiedName = qualifiedTblName;
-      String parentDatabaseName = fkCols.get(0).parentDatabaseName;
-      String parentTableName = fkCols.get(0).parentTableName;
-      List<String> parentTableQualifiedName = new ArrayList<>();
-      if (parentDatabaseName != null && !parentDatabaseName.isEmpty()) {
-        parentTableQualifiedName.add(parentDatabaseName);
-      }
-      parentTableQualifiedName.add(parentTableName);
-      Table parentTab = null;
-      try {
-        // TODO: We have a cache for Table objects in SemanticAnalyzer::getTableObjectByName()
-        // We need to move that cache elsewhere and use it from places like this.
-        parentTab = Hive.get().getTable(parentDatabaseName, parentTableName);
-      } catch (HiveException e) {
-        throw new RuntimeException(e);
-      }
-      if (parentTab == null) {
-        LOG.error("Table for primary key not found: "
-              + "databaseName: " + parentDatabaseName+ ", "
+    if (foreignKeyInfo != null && !foreignKeyInfo.getForeignKeys().isEmpty()) {
+      for (List<ForeignKeyCol> fkCols : foreignKeyInfo.getForeignKeys().values()) {
+        String parentDatabaseName = fkCols.get(0).parentDatabaseName;
+        String parentTableName = fkCols.get(0).parentTableName;
+        String qualifiedName;
+        List<String> parentTableQualifiedName = new ArrayList<>();
+        if (parentDatabaseName != null && !parentDatabaseName.isEmpty()) {
+          parentTableQualifiedName.add(parentDatabaseName);
+          parentTableQualifiedName.add(parentTableName);
+          qualifiedName = TableName.getDbTable(
+              parentDatabaseName, parentTableName);
+        } else {
+          parentTableQualifiedName.add(parentTableName);
+          qualifiedName = parentTableName;
+        }
+        Table parentTab = getTable(qualifiedName);
+        if (parentTab == null) {
+          LOG.error("Table for primary key not found: "
+              + "databaseName: " + parentDatabaseName + ", "
               + "tableName: " + parentTableName);
-        return ImmutableList.of();
-      }
-      ImmutableList.Builder<IntPair> keys = ImmutableList.builder();
-      for (ForeignKeyCol fkCol : fkCols) {
-        int fkPos;
-        for (fkPos = 0; fkPos < rowType.getFieldNames().size(); fkPos++) {
-          String fkColName = rowType.getFieldNames().get(fkPos);
-          if (fkColName.equals(fkCol.childColName)) {
-            break;
-          }
+          return ImmutableList.of();
         }
-        int pkPos;
-        for (pkPos = 0; pkPos < parentTab.getAllCols().size(); pkPos++) {
-          String pkColName = parentTab.getAllCols().get(pkPos).getName();
-          if (pkColName.equals(fkCol.parentColName)) {
-            break;
+        ImmutableList.Builder<IntPair> keys = ImmutableList.builder();
+        for (ForeignKeyCol fkCol : fkCols) {
+          int fkPos;
+          for (fkPos = 0; fkPos < rowType.getFieldNames().size(); fkPos++) {
+            String fkColName = rowType.getFieldNames().get(fkPos);
+            if (fkColName.equals(fkCol.childColName)) {
+              break;
+            }
           }
+          int pkPos;
+          for (pkPos = 0; pkPos < parentTab.getAllCols().size(); pkPos++) {
+            String pkColName = parentTab.getAllCols().get(pkPos).getName();
+            if (pkColName.equals(fkCol.parentColName)) {
+              break;
+            }
+          }
+          if (fkPos == rowType.getFieldNames().size()
+              || pkPos == parentTab.getAllCols().size()) {
+            LOG.error("Column for foreign key definition " + fkCol + " not found");
+            return ImmutableList.of();
+          }
+          keys.add(IntPair.of(fkPos, pkPos));
         }
-        if (fkPos == rowType.getFieldNames().size()
-            || pkPos == parentTab.getAllCols().size()) {
-          LOG.error("Column for foreign key definition " + fkCol + " not found");
-          return ImmutableList.of();
-        }
-        keys.add(IntPair.of(fkPos, pkPos));
+        builder.add(RelReferentialConstraintImpl.of(qualifiedTblName,
+            parentTableQualifiedName, keys.build()));
       }
-      builder.add(RelReferentialConstraintImpl.of(foreignKeyTableQualifiedName,
-              parentTableQualifiedName, keys.build()));
     }
     return builder.build();
   }
 
+  private Table getTable(String tableName) {
+    if (!tablesCache.containsKey(tableName)) {
+      try {
+        Table table = db.getTable(tableName);
 
 Review comment:
   This is the qualified table name (see L1226 in Hive.java), not sure what you mean with
NULL for db?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 255439)
    Time Spent: 1h 40m  (was: 1.5h)

> CBO: Copying TableRelOptHiveTable has metastore traffic
> -------------------------------------------------------
>
>                 Key: HIVE-21818
>                 URL: https://issues.apache.org/jira/browse/HIVE-21818
>             Project: Hive
>          Issue Type: Bug
>          Components: CBO
>            Reporter: Gopal V
>            Assignee: Jesus Camacho Rodriguez
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-21818.01.patch, HIVE-21818.02.patch, HIVE-21818.03.patch, HIVE-21818.04.patch,
HIVE-21818.04.patch, HIVE-21818.05.patch, HIVE-21818.05.patch, HIVE-21818.05.patch, HIVE-21818.patch
>
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> While the optimizer is running, whenever it makes a copy of the TableScan to perform
potential rewrites, there is Hive metastore traffic from inside CBO optimizer.
> {code}
>   public RelOptHiveTable(RelOptSchema calciteSchema, RelDataTypeFactory typeFactory,
List<String> qualifiedTblName,
>       RelDataType rowType, Table hiveTblMetadata, List<ColumnInfo> hiveNonPartitionCols,
>       List<ColumnInfo> hivePartitionCols, List<VirtualColumn> hiveVirtualCols,
HiveConf hconf,
>       Map<String, PrunedPartitionList> partitionCache, Map<String, ColumnStatsList>
colStatsCache,
>       AtomicInteger noColsMissingStats) { ....
>     Pair<List<ImmutableBitSet>, List<ImmutableBitSet>> constraintKeys
= generateKeys();
>     this.keys = constraintKeys.left;
>     this.nonNullablekeys = constraintKeys.right;
>     this.referentialConstraints = generateReferentialConstraints();
> }
> {code}
> This is triggered from the rules as the partition pruner
> {code}
>   protected void perform(RelOptRuleCall call, Filter filter,
>       HiveTableScan tScan) {
>     // Original table
>     RelOptHiveTable hiveTable = (RelOptHiveTable) tScan.getTable();
>     // Copy original table scan and table
>     HiveTableScan tScanCopy = tScan.copyIncludingTable(tScan.getRowType());
>     RelOptHiveTable hiveTableCopy = (RelOptHiveTable) tScanCopy.getTable();
> ...
>     if (StringUtils.equals(hiveTableCopy.getPartitionListKey(), hiveTable.getPartitionListKey()))
{
>       // Nothing changed, we do not need to produce a new expression
>       return;
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message