hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-21822) Expose LlapDaemon metrics through a new API method
Date Tue, 04 Jun 2019 18:18:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-21822?focusedWorklogId=253905&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-253905
]

ASF GitHub Bot logged work on HIVE-21822:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Jun/19 18:17
            Start Date: 04/Jun/19 18:17
    Worklog Time Spent: 10m 
      Work Description: odraese commented on pull request #657: HIVE-21822: Expose LlapDaemon
metrics through a new API method
URL: https://github.com/apache/hive/pull/657#discussion_r290429935
 
 

 ##########
 File path: llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapProtocolServerImpl.java
 ##########
 @@ -302,6 +306,18 @@ public GetTokenResponseProto getDelegationToken(RpcController controller,
     return responseProtoBuilder.build();
   }
 
+  @Override
+  public LlapDaemonProtocolProtos.GetLoadMetricsResponseProto getLoadMetrics(final RpcController
controller,
+      final LlapDaemonProtocolProtos.GetLoadMetricsRequestProto request) throws ServiceException
{
+    LlapDaemonProtocolProtos.GetLoadMetricsResponseProto.Builder responseProtoBuilder =
 
 Review comment:
   We already have a metrics provider (LlapDaemonExecutorMetrics) here. Shouldn't we just
dump all defined counters (of this metrics) as key/value entries to a Map instead of "splitting
out" two separate values? From an extensibility perspective, I would like to avoid that for
each upcoming (required daemon) counter, we have to
   
   - add a new value to the proto message (and regenerate the protobuf impl)
   - add a new getter to the metrics
   - change the code to copy the value from the metric to the message
   
   We can't simply wrap the metrics instance into a proto response but it should be fairy
easy ti generically convert it into a Map (every counter already has a string identifier)
and return that map as part of the message.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 253905)

> Expose LlapDaemon metrics through a new API method
> --------------------------------------------------
>
>                 Key: HIVE-21822
>                 URL: https://issues.apache.org/jira/browse/HIVE-21822
>             Project: Hive
>          Issue Type: Sub-task
>          Components: llap
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-21822.patch
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> We should add a new API method to access specific LlapDaemon metrics which would provide
information to TezAMs to make good decisions on load balancing tasks



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message