hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-21891) Break up DDLTask - cleanup
Date Wed, 19 Jun 2019 03:24:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-21891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867190#comment-16867190
] 

Hive QA commented on HIVE-21891:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:red}-1{color} | {color:red} @author {color} | {color:red}  0m  0s{color} | {color:red}
The patch appears to contain 5 @author tags which the community has agreed to not allow in
code contributions. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 34s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 20s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  9m 46s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  4m 58s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m 13s{color} | {color:blue}
ql in master has 2253 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 25s{color} | {color:blue}
contrib in master has 10 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 39s{color} | {color:blue}
hcatalog/core in master has 28 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 46s{color} | {color:blue}
itests/hive-unit in master has 2 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 48s{color} | {color:blue}
itests/util in master has 44 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  8m 58s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 29s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m 34s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  9m 41s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  9m 41s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  1m  3s{color} | {color:red}
ql: The patch generated 3 new + 1306 unchanged - 3 fixed = 1309 total (was 1309) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  2m 45s{color} | {color:red}
root: The patch generated 3 new + 2185 unchanged - 3 fixed = 2188 total (was 2188) {color}
|
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  0s{color} | {color:red}
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.
Refer https://git-scm.com/docs/git-apply {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  2s{color} | {color:green}
The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 41s{color} | {color:red}
itests/hive-unit cannot run computeBugHistory from findbugs {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 46s{color} | {color:red}
itests/util cannot run computeBugHistory from findbugs {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m 29s{color} | {color:red}
itests_util generated 2 new + 9 unchanged - 0 fixed = 11 total (was 9) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 19s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 93m  5s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  xml  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-17639/dev-support/hive-personality.sh
|
| git revision | master / 1f20cc3 |
| Default Java | 1.8.0_111 |
| @author | http://104.198.109.242/logs//PreCommit-HIVE-Build-17639/yetus/author-tags.txt
|
| findbugs | v3.0.0 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-17639/yetus/diff-checkstyle-ql.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-17639/yetus/diff-checkstyle-root.txt
|
| whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-17639/yetus/whitespace-eol.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-17639/yetus/patch-findbugs-itests_hive-unit.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-17639/yetus/patch-findbugs-itests_util.txt
|
| javadoc | http://104.198.109.242/logs//PreCommit-HIVE-Build-17639/yetus/diff-javadoc-javadoc-itests_util.txt
|
| modules | C: ql contrib hcatalog/core . itests/hive-unit itests/util U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-17639/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Break up DDLTask - cleanup
> --------------------------
>
>                 Key: HIVE-21891
>                 URL: https://issues.apache.org/jira/browse/HIVE-21891
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Hive
>    Affects Versions: 3.1.1
>            Reporter: Miklos Gergely
>            Assignee: Miklos Gergely
>            Priority: Major
>              Labels: refactor-ddl
>             Fix For: 4.0.0
>
>         Attachments: HIVE-21891.01.patch
>
>
> DDLTask was a huge class, more than 5000 lines long. The related DDLWork was also a huge
class, which had a field for each DDL operation it supported. The goal was to refactor these
in order to have everything cut into more handleable classes under the package  org.apache.hadoop.hive.ql.exec.ddl:
>  * have a separate class for each operation
>  * have a package for each operation group (database ddl, table ddl, etc), so the amount
of classes under a package is more manageable
>  * make all the requests (DDLDesc subclasses) immutable - most of them are now
>  * DDLTask should be agnostic to the actual operations
>  * right now let's ignore the issue of having some operations handled by DDLTask which
are not actual DDL operations (lock, unlock, desc...)
> In the interim time when there were two DDLTask and DDLWork classes in the code base
the new ones in the new package were called DDLTask2 and DDLWork2 thus avoiding the usage
of fully qualified class names where both the old and the new classes were in use.
> Step #12: rename DDLTask2 and DDLWork2, now that they are alone. Remove the old DDLDesc.
Instead of registering, now DDLTask finds the DDLOperations, and registers them itself.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message