hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-21962) Replacing ArrayList params with List in and around PlanUtils and MapWork
Date Mon, 22 Jul 2019 10:56:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-21962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890071#comment-16890071
] 

Hive QA commented on HIVE-21962:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12975370/HIVE-21962.2.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 16682 tests passed

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18127/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18127/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18127/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12975370 - PreCommit-HIVE-Build

> Replacing ArrayList params with List in and around PlanUtils and MapWork
> ------------------------------------------------------------------------
>
>                 Key: HIVE-21962
>                 URL: https://issues.apache.org/jira/browse/HIVE-21962
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Ivan Suller
>            Assignee: Ivan Suller
>            Priority: Minor
>         Attachments: HIVE-21962.1.patch, HIVE-21962.1.patch, HIVE-21962.2.patch, HIVE-21962.2.patch
>
>
> Using the implementing class is usually a bad practice. OO suggest to use the least restrictive
interface instead. ArrayList is used in many-many methods as a parameter - this is just a
tiny part of this work.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Mime
View raw message