hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laszlo Bodor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-21962) Replacing ArrayList params with List in and around PlanUtils and MapWork
Date Tue, 30 Jul 2019 21:58:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-21962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896558#comment-16896558
] 

Laszlo Bodor commented on HIVE-21962:
-------------------------------------

+1

> Replacing ArrayList params with List in and around PlanUtils and MapWork
> ------------------------------------------------------------------------
>
>                 Key: HIVE-21962
>                 URL: https://issues.apache.org/jira/browse/HIVE-21962
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Ivan Suller
>            Assignee: Ivan Suller
>            Priority: Minor
>         Attachments: HIVE-21962.1.patch, HIVE-21962.1.patch, HIVE-21962.2.patch, HIVE-21962.2.patch
>
>
> Using the implementing class is usually a bad practice. OO suggest to use the least restrictive
interface instead. ArrayList is used in many-many methods as a parameter - this is just a
tiny part of this work.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Mime
View raw message