hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-22003) Shared work optimizer may leave semijoin branches in plan that are not used
Date Mon, 22 Jul 2019 23:47:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-22003?focusedWorklogId=280703&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-280703
]

ASF GitHub Bot logged work on HIVE-22003:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Jul/19 23:46
            Start Date: 22/Jul/19 23:46
    Worklog Time Spent: 10m 
      Work Description: jcamachor commented on pull request #729: HIVE-22003
URL: https://github.com/apache/hive/pull/729#discussion_r306078025
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java
 ##########
 @@ -486,6 +510,75 @@ private static boolean sharedWorkOptimization(ParseContext pctx, SharedWorkOptim
     return mergedExecuted;
   }
 
+  private static void replaceSemijoinExpressions(TableScanOperator tsOp, List<ExprNodeDesc>
semijoinExprNodes) {
 
 Review comment:
   Yes, that is correct. But it is not the branch, it is only the expressions.
   
   The reason is that we have already verified that the SJ expressions hitting both TS operators
are the same. At the current step we are already merging. Thus, what we want now is that the
SJ expression from the retainable branch is on top of the discardable branch too. Since we
already had a method to push the filter expressions on top of the discardable TS (`pushFilterToTopOfTableScan`),
what I have done is that we remove the old SJ expressions from the discardable TS (and follow-up
Filters if present) and we add the SJ expressions from the retainable TS, hence automatically
they will be pushed on top of the discardable TS. Then we can just remove the discardable
TS operator and connect its output operators with the retainable TS operator.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 280703)
    Time Spent: 1h  (was: 50m)

> Shared work optimizer may leave semijoin branches in plan that are not used
> ---------------------------------------------------------------------------
>
>                 Key: HIVE-22003
>                 URL: https://issues.apache.org/jira/browse/HIVE-22003
>             Project: Hive
>          Issue Type: Bug
>          Components: Physical Optimizer
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Jesus Camacho Rodriguez
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-22003.01.patch, HIVE-22003.01.patch, HIVE-22003.patch
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> This may happen only when the TS are the only operators that are shared. Repro attached
in q file.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Mime
View raw message